Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for viewing tags #11515

Merged
merged 13 commits into from
May 8, 2023
Merged

Support for viewing tags #11515

merged 13 commits into from
May 8, 2023

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Apr 11, 2023 •
edited
Loading

  • Tests written, or not not needed

@tobiasKaminsky tobiasKaminsky mentioned this pull request Apr 11, 2023
Closed
7 tasks
@tobiasKaminsky tobiasKaminsky marked this pull request as ready for review May 3, 2023 08:26
@tobiasKaminsky @AndyScherzinger
Support for viewing tags
f196bfd 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @AndyScherzinger
color
60c8c35 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @AndyScherzinger
show tags in file details
d262b69 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @AndyScherzinger
correct background color in detail view
eaf8462 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @AndyScherzinger
show two tags
c72354b 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @AndyScherzinger
fix NPE, polish
d484a88 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @AndyScherzinger
use chip group
d9e0304 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @AndyScherzinger
wip
31560bf 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @AndyScherzinger
wip
f6e3bcc 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @AndyScherzinger
revert to master lib
8a2d2c1 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @AndyScherzinger
empty array list for tags
3ab8cc3 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @AndyScherzinger
fix
9686821 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.25.0 milestone May 4, 2023
@AndyScherzinger
Copy link
Member

before after non-root-folder
before after folder

@AndyScherzinger
Optimize layout for tags and allowing for tags-multi-line growth of t…
e88ed46 
…he line item if needed

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions
Copy link

github-actions bot commented May 4, 2023

blue-Light-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11515-Screenshot-blue-Light-13-38

AndyScherzinger
AndyScherzinger approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine for me 👍

@github-actions
Copy link

github-actions bot commented May 4, 2023

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11515-Screenshot-blue-Light-14-18

@AndyScherzinger
Copy link
Member

AndyScherzinger commented May 4, 2023 •
edited
Loading

@tobiasKaminsky the multiline as mentioned on the chat has been approved by Jan for the moment since we can't ellipsize

@github-actions
Copy link

github-actions bot commented May 4, 2023

Codacy

Lint

TypemasterPR
Warnings7676
Errors00

SpotBugs

CategoryBaseNew
Bad practice2727
Correctness5151
Dodgy code324323
Internationalization99
Multithreaded correctness99
Performance5858
Security1818
Total496495

@github-actions
Copy link

github-actions bot commented May 4, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11515.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/8497-IT-master-17-54

@AndyScherzinger AndyScherzinger merged commit 3e1f61a into master May 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the tags branch May 8, 2023 08:57
@joshtrichards joshtrichards mentioned this pull request Dec 12, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasKaminsky @AndyScherzinger @nextcloud-android-bot