Search event refactor

[imjarp]

This PR fixes #251 caused in a Search event

[mario]

@imjarp thanks for the PR, and someone will definitely look into it.

However I highly doubt it fixes the bug you mention because at the time it was reported EventBus wasn't even used :)

[imjarp]

@mario Sorry, maybe the comment is wrong :( , this do not completely fix the bug , but with the search event (favorites, photos, shared) is more clearly how to reproduce it , i attach the evidence with the latest version of NextCloud master. Hope is helpful :)

BTW hadn`t time to check it but i think the problem comes with WrapperListAdapter ListView.addFooterView

if i can help with anything just tell me :)

The error in the logcat
07-14 11:09:43.683 6597-6597/com.nextcloud.client E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.nextcloud.client, PID: 6597
java.lang.IndexOutOfBoundsException: Invalid index 1, size is 1
at java.util.ArrayList.throwIndexOutOfBoundsException(ArrayList.java:255)
at java.util.ArrayList.get(ArrayList.java:308)
at android.widget.HeaderViewListAdapter.isEnabled(HeaderViewListAdapter.java:164)
at android.widget.AbsListView.onTouchDown(AbsListView.java:3931)

With fav search

With shared search

Logcat

share_search_logcat.txt

[mario]

@AndyScherzinger @tobiasKaminsky we should test and merge this for 1.5 if it's all fine.

[AndyScherzinger]

@tobiasKaminsky @imjarp can you please have a look at this and also update it to latest master? If it works I'd also say merge for next release.

[imjarp]

Sure i will check it tomorrow

[tobiasKaminsky]

Closing due to inactivity, but keeping branch.