Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate OwncloudClient - Comments #12464

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Deprecate OwncloudClient - Comments #12464

merged 5 commits into from
Jun 13, 2024

Conversation

ZetaTom
Copy link
Collaborator

@ZetaTom ZetaTom commented Jan 30, 2024 •
edited by tobiasKaminsky
Loading

This is one of a series of pull requests which aim to replace all instances of OwnCloudClient with NextcloudClient. The reason for this change is that the newer NextcloudClient uses OkHttp, replacing the outdated Jackrabbit methods.

Specifically, this pull request implements the following:

  • Tests written, or not not needed

@ZetaTom ZetaTom self-assigned this Jan 30, 2024
@ZetaTom ZetaTom mentioned this pull request Jan 30, 2024
Open
7 tasks
@github-actions GitHub Actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@tobiasKaminsky tobiasKaminsky mentioned this pull request Jun 11, 2024
Open
@tobiasKaminsky tobiasKaminsky self-requested a review June 12, 2024 09:55
@tobiasKaminsky tobiasKaminsky marked this pull request as ready for review June 12, 2024 13:45
ZetaTom and others added 4 commits June 12, 2024 15:46
@ZetaTom @tobiasKaminsky
Adapt OperationsService for NextcloudClient
ebc67f6 
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
@ZetaTom @tobiasKaminsky
Deprecate OwncloudClient - Comments
c1d2d8a 
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
@ZetaTom @tobiasKaminsky
Set androidLibraryVersion
fb0a703 
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
@tobiasKaminsky
fix after rebase
82b5962 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
set library hash
8fd50ad 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings6969
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6868
Dodgy code340340
Experimental11
Internationalization77
Multithreaded correctness66
Performance5757
Security1818
Total561561

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12464.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12464-Screenshot-blue-Light-14-09

@tobiasKaminsky tobiasKaminsky merged commit 0a8277e into master Jun 13, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees

@ZetaTom ZetaTom

Labels
3. to review feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZetaTom @tobiasKaminsky