Try to only process changed files for auto upload #12719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasMayerDev
force-pushed
the
autoupload_only_check_changes
branch
from
6414d69 to
24f97c2
Compare
JonasMayerDev
force-pushed
the
autoupload_only_check_changes
branch
from
24f97c2 to
3529d0a
Compare
alperozturk96
force-pushed
the
autoupload_only_check_changes
branch
from
3529d0a to
ef8e5f2
Compare
alperozturk96
approved these changes
Mar 22, 2024
AndyScherzinger
approved these changes
Mar 22, 2024
|
/backport to stable-3.28 |
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
JonasMayerDev
force-pushed
the
autoupload_only_check_changes
branch
from
54e5958 to
22913b8
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12719.apk |
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12719-Screenshot-blue-Light-10-28 |
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initiated by #12596 the idea was to reduce the times the full file system scan for changed files for auto upload is needed. This PR adds that when ever ContentObserverWorker detects media files (so only images and videos) change, the FilesSyncWorker does not go through every file in the corresponding folders. Now it only checks which sync folder (if any) the file belongs to and only enqueues this file for upload.
Test this PR
To test this functionality, one can set up the camera folder as an auto upload folder and take pictures. The upload of the file should start after about at most 15s automatically in the background.
This behavior is the same as before, but it now should take less time for especially large media folders, and it does not use a foreground worker for the sync worker.
Known Issues
Sometimes some changes are not detected when too many changes happen one after another and the upload of those files stops until the app is opened. So sometime files are missing from upload. Though this is not optimal, it seems like this is an issue with the content observer worker. As we not really rely on this functionality (a full file system scan is still scheduled every 15 min) I think this is still better than the functionality before. So this functionality should rather be seen as a bonus that uploads files faster if it works but if not there is still a fallback.