Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-fix Encrypted Large File Upload #12723

Merged
merged 13 commits into from
Mar 25, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Mar 22, 2024

  • Tests written, or not not needed

How to Test

  1. Create a new encrypted folder
  2. Upload big file
  3. Download same file
  4. Open File

Known Issues

If the upload fails once for the encrypted folder, subsequent uploads will fail. We are still working on it. That fix will be in separate PR. Therefore, please create a new folder for testing.

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the bugfix/encrypted-large-file-upload branch from 290e643 to 84d8c78 Compare March 22, 2024 14:11
Copy link

Codacy

Lint

TypemasterPR
Warnings7171
Errors33

SpotBugs

CategoryBaseNew
Bad practice6867
Correctness6868
Dodgy code350350
Experimental21
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5658
Security1919
Total578578

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12723.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@tobiasKaminsky
Copy link
Member

/backport to stable-3.28

@tobiasKaminsky tobiasKaminsky merged commit b7ee062 into master Mar 25, 2024
19 of 21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/encrypted-large-file-upload branch March 25, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants