-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add whats new screen for version 2.0.0 #1282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Well, Photo & Video folders are instant on Android 7+ with the new code. Custom folders are not however. |
|
I thought about how to explain this on a more generic level and came to the conclusion to "lower" the expectation from "instant" to "it may take some time, but it is reliable"... But it is only a first suggestion.. |
|
Yup, it's good to downplay advantages :P Except "What's new in 1.5" is just strangely aligned, but otherwise ok. |
|
Also are we only going to show this 1 screen on upgrade? |
in first post I asked this question also:
At least 3 items, max 5, I would say. |
|
For What's new I'd say we just mention the new auto upload enhancement and leave the 3 for the initial introduction. So I am fine as is content-wise but also think the headline is a bit strange. Since everything is centered I'd say the headline should also be centered :) |
152b0c3 to
a568604
Compare
|
I'm fine with adding search. But mention it's 12+. |
2d19754 to
79e6db9
Compare
a568604 to
dd53e2b
Compare
|
I will later add some new slides, but currently my inkscape is broken :-/ |
|
Possible further options:
|
|
I'd say leave out push notifications since they aren't available on non GPlay releases but would then still be shown on these installations. |
|
@AndyScherzinger you can do IFs based on the flavour ;) But you guys decide, do it and merge! |
|
"Not only in current folder" -> "Across entire account" |
|
Let me know when this is corrected and can be merged! |
9ec94df to
ebe4eaa
Compare
other than that it is fine. @mario beware that this can only be merged to the changelog branch (as configured in this PR) and that the changelog branch cannot be merged before final release since it bumps the version to FINAL. |
|
@AndyScherzinger that's fine. Are we only missing lint branch for RC? What else is missing for RC? (Manifest changes?) |
|
It's the lint branchs, the lib update and version bump. I'll ping you on all PRs as soon as the have gone through droneCI 🚀 |
ebe4eaa to
07611cc
Compare
28e9d3d to
4d9871b
Compare
You can easily rebranch if you click on "edit" (where you can change the title of the PR). |
4d9871b to
ce0557b
Compare
|
mentioned in a comment = comment mentions |
|
Thanks @jasonbayton, I changed the wording |
01f2e6d to
363c7f9
Compare
7737f04 to
b0028b6
Compare
363c7f9 to
b4d1ecb
Compare
b0028b6 to
c6b453a
Compare
b4d1ecb to
660b92e
Compare
c6b453a to
074fbcb
Compare
- changed branch that it is mergeable into master for translation
# Conflicts: # scripts/lint/lint-results.txt # src/main/java/com/owncloud/android/features/FeatureList.java
|
For translation via transifex we need to get this soon into master:
|
|
@tobiasKaminsky I'll rebase it and merge it to the changelog branch. AS seen in the commits this branch isn't mergeable to master since it is based on changelog, not on master... |
|
@tobiasKaminsky whatever happened this branch is now a rebase hell!!! :/ |
|
Closing in favor of #1363 |







On upgrade:

On first run: (changed wording from instant upload to auto upload)

Do we want to add another slide for 1.5?
Big features that are not immediately visible are in my opinion: