Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

On upgrade:
2017-08-08-114710

On first run: (changed wording from instant upload to auto upload)
2017-08-08-113643

Do we want to add another slide for 1.5?
Big features that are not immediately visible are in my opinion:

  • search
  • contact backup

@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 1.5.0 milestone Aug 8, 2017
@mario
Copy link
Contributor

mario commented Aug 8, 2017

Well, Photo & Video folders are instant on Android 7+ with the new code. Custom folders are not however.

@tobiasKaminsky
Copy link
Member Author

I thought about how to explain this on a more generic level and came to the conclusion to "lower" the expectation from "instant" to "it may take some time, but it is reliable"...

But it is only a first suggestion..

@mario
Copy link
Contributor

mario commented Aug 8, 2017

Yup, it's good to downplay advantages :P

Except "What's new in 1.5" is just strangely aligned, but otherwise ok.

@mario
Copy link
Contributor

mario commented Aug 8, 2017

Also are we only going to show this 1 screen on upgrade?

@tobiasKaminsky
Copy link
Member Author

Also are we only going to show this 1 screen on upgrade?

in first post I asked this question also:

Do we want to add another slide for 1.5?
Big features that are not immediately visible are in my opinion:

  • search
  • contact backup

At least 3 items, max 5, I would say.

@AndyScherzinger
Copy link
Member

For What's new I'd say we just mention the new auto upload enhancement and leave the 3 for the initial introduction. So I am fine as is content-wise but also think the headline is a bit strange. Since everything is centered I'd say the headline should also be centered :)

@tobiasKaminsky
Copy link
Member Author

2017-08-08-114710 -> 2017-08-08-160236

I think for such a big release two more slides would be really cool.
Especially promoting the search feature is worth it.

@tobiasKaminsky tobiasKaminsky changed the base branch from master to changelog August 8, 2017 14:14
@AndyScherzinger AndyScherzinger force-pushed the whatsNew1_5 branch 2 times, most recently from 152b0c3 to a568604 Compare August 8, 2017 14:24
@mario
Copy link
Contributor

mario commented Aug 8, 2017

I'm fine with adding search. But mention it's 12+.

@AndyScherzinger AndyScherzinger changed the title Add whats new screen for version 1.5 Add whats new screen for version 2.0.0 Aug 9, 2017
@tobiasKaminsky
Copy link
Member Author

I will later add some new slides, but currently my inkscape is broken :-/

@mario
Copy link
Contributor

mario commented Aug 9, 2017

Possible further options:

  • Search (for NC12+)
  • Favorites (same, NC12+)
  • Fingerprint security
  • Push notifications !!! (NC12+)

@AndyScherzinger
Copy link
Member

I'd say leave out push notifications since they aren't available on non GPlay releases but would then still be shown on these installations.

@mario
Copy link
Contributor

mario commented Aug 9, 2017

@AndyScherzinger you can do IFs based on the flavour ;) But you guys decide, do it and merge!

@tobiasKaminsky
Copy link
Member Author

My ideas...I am not a real pro at graphics, so feedback is always welcome, also on the text.

2017-08-10-151521 2017-08-10-151525
2017-08-10-151528 2017-08-10-151532
2017-08-10-151535

@mario
Copy link
Contributor

mario commented Aug 10, 2017

"Not only in current folder" -> "Across entire account"
"Use color to distinguish accounts" -> "Use color to distinguish between accounts"

@mario
Copy link
Contributor

mario commented Aug 10, 2017

Let me know when this is corrected and can be merged!

@AndyScherzinger
Copy link
Member

  • Search: Show listing in large without the phone (which was used to illustrate the camera for auto upload)
  • Notification: mix it with activity icon (flash)

other than that it is fine.

@mario beware that this can only be merged to the changelog branch (as configured in this PR) and that the changelog branch cannot be merged before final release since it bumps the version to FINAL.

@mario
Copy link
Contributor

mario commented Aug 10, 2017

@AndyScherzinger that's fine. Are we only missing lint branch for RC? What else is missing for RC? (Manifest changes?)

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Aug 10, 2017

It's the lint branchs, the lib update and version bump.

I'll ping you on all PRs as soon as the have gone through droneCI 🚀

@tobiasKaminsky
Copy link
Member Author

beware that this can only be merged to the changelog branch (as configured in this PR)

You can easily rebranch if you click on "edit" (where you can change the title of the PR).

@jasonbayton
Copy link
Member

jasonbayton commented Aug 11, 2017

mentioned in a comment = comment mentions
announcements posted by an admin = admin announcements
separation between image & video = separation of images & videos

@tobiasKaminsky
Copy link
Member Author

Thanks @jasonbayton, I changed the wording

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Aug 17, 2017

👍 fine by me

Approved with PullApprove

- changed branch that it is mergeable into master for translation
# Conflicts:
#	scripts/lint/lint-results.txt
#	src/main/java/com/owncloud/android/features/FeatureList.java
@tobiasKaminsky
Copy link
Member Author

For translation via transifex we need to get this soon into master:

  • using versionCode instead of string
  • changed branch that it is mergeable into master

@AndyScherzinger
Copy link
Member

@tobiasKaminsky I'll rebase it and merge it to the changelog branch. AS seen in the commits this branch isn't mergeable to master since it is based on changelog, not on master...

@AndyScherzinger
Copy link
Member

@tobiasKaminsky whatever happened this branch is now a rebase hell!!! :/

@AndyScherzinger AndyScherzinger mentioned this pull request Aug 17, 2017
@tobiasKaminsky
Copy link
Member Author

Closing in favor of #1363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants