Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make auto upload light working again #1292

Merged
merged 7 commits into from
Aug 10, 2017
Merged

Conversation

tobiasKaminsky
Copy link
Member

No description provided.

@mario
Copy link
Contributor

mario commented Aug 9, 2017

👍

Looks decent :)

Approved with PullApprove

@mario
Copy link
Contributor

mario commented Aug 9, 2017

Let's get this into 2.0.0 @AndyScherzinger

@AndyScherzinger
Copy link
Member

of course :) While it needs to hide the expert mode I guess ;)

@mario
Copy link
Contributor

mario commented Aug 10, 2017

I agree. Can we disable expert mode option to show at all if light auto upload is present?

@mario
Copy link
Contributor

mario commented Aug 10, 2017

Hm, without compiling it looks like you don't remove the "Expert mode" entry from preferences, but just don't set what happens when you click?

@tobiasKaminsky
Copy link
Member Author

Right, thank you!
I was just too fast and did not even teste it as I thought it is just a minor one... :S

@mario
Copy link
Contributor

mario commented Aug 10, 2017

👍

Decent enough, thanks for the correction!

@AndyScherzinger please ;)

Approved with PullApprove

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Aug 10, 2017

👍 fine by me :)

Approved with PullApprove

@AndyScherzinger AndyScherzinger merged commit 2b2fb45 into master Aug 10, 2017
@AndyScherzinger AndyScherzinger deleted the autoUploadLight branch August 10, 2017 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants