Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-Fix Percentage Value During Download or Upload #13145

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jun 17, 2024

  • Tests written, or not not needed

Most of the time, the percentage value is correct. However, some users have encountered abnormally large integer values at the end of the upload or download progress. To suppress this issue until the root cause is identified, coerceAtMost and the OnDataTransferProgressListener extension used to prevent incorrect usage.

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the bugfix/percentage-during-download-or-upload branch from b969da8 to 7ee7542 Compare June 18, 2024 13:03
Copy link

Codacy

Lint

TypemasterPR
Warnings6868
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6868
Dodgy code338338
Experimental11
Internationalization77
Multithreaded correctness66
Performance5757
Security1818
Total559559

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13145.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link
Collaborator

@JonasMayerDev JonasMayerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not reproduce bug but works for me and code looks good.

Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@AndyScherzinger AndyScherzinger merged commit 04858b0 into master Jun 19, 2024
20 of 21 checks passed
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.30.0 milestone Jun 19, 2024
@joshtrichards joshtrichards mentioned this pull request Jul 7, 2024
4 tasks
@tobiasKaminsky tobiasKaminsky deleted the bugfix/percentage-during-download-or-upload branch October 7, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants