Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Login Flow V2 Response #13159

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jun 20, 2024

  • Tests written, or not not needed

What this PR does?

Prevents crash and gives feedback to user about the process.

How to Test?

  1. Try to log in with different accounts multiple times.

@alperozturk96 alperozturk96 changed the title Handle Login Flow V2 esponse correctly Handle Login Flow V2 Response Jun 20, 2024
@alperozturk96 alperozturk96 linked an issue Jun 20, 2024 that may be closed by this pull request
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Copy link

Codacy

Lint

TypemasterPR
Warnings6868
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6868
Dodgy code338338
Experimental11
Internationalization77
Multithreaded correctness66
Performance5757
Security1818
Total559559

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13159.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 merged commit f8e49f2 into master Jun 26, 2024
21 checks passed
@AndyScherzinger AndyScherzinger deleted the handle-login-flow-v2-response branch June 26, 2024 08:09
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.30.0 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

com.google.gson.stream.MalformedJsonException
2 participants