Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filesync worker persistant #13217

Closed
wants to merge 4 commits into from

Conversation

JonasMayerDev
Copy link
Collaborator

@JonasMayerDev JonasMayerDev commented Jul 1, 2024

Should Fix #13035

  • Tests written, or not not needed

@tobiasKaminsky tobiasKaminsky linked an issue Jul 3, 2024 that may be closed by this pull request
5 tasks
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
@JonasMayerDev JonasMayerDev force-pushed the make-filesyncworker-persistant branch from b803588 to 5dd0611 Compare July 4, 2024 20:24
Copy link

github-actions bot commented Jul 4, 2024

Codacy

Lint

TypemasterPR
Warnings6363
Errors33

SpotBugs

CategoryBaseNew
Bad practice6363
Correctness6363
Dodgy code308309
Experimental11
Internationalization77
Multithreaded correctness66
Performance5252
Security1818
Total518519

SpotBugs increased!

Copy link

github-actions bot commented Jul 4, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13217.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

github-actions bot commented Jul 4, 2024

@JonasMayerDev
Copy link
Collaborator Author

JonasMayerDev commented Jul 8, 2024

The Idea tested in this PR to remember in the DB when, which files were scanned seems to be unfeasible right now.
The overhead produced when interacting with the DB (adding all files) every time the worker runs adds too much overhead (in my testing, nearly 65% in the best case). Also, trying to interact with the DB in batches did not solve the problem. I will close this PR and try another Idea I had while testing in another PR #13262 to keep it organized and documented.

Copy link

github-actions bot commented Aug 6, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@tobiasKaminsky tobiasKaminsky deleted the make-filesyncworker-persistant branch October 7, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only pictures are enabled but videos also auto-synced Remove foreground worker for auto upload
1 participant