Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "BugFix - Change Layout Gravity Of Empty View To The Center" #13407

Merged

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Aug 12, 2024

Reverts #13380 due to broken screenshot tests. We will fix the issue without changing the layout gravity via different PR.

Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the revert-13380-bugfix/empty-view-gravity-alignment branch from bead9ca to 4387c4c Compare August 12, 2024 10:26
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13407.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

Codacy

Lint

TypemasterPR
Warnings6262
Errors33

SpotBugs

CategoryBaseNew
Bad practice6363
Correctness6464
Dodgy code305305
Experimental11
Internationalization77
Multithreaded correctness66
Performance5252
Security1818
Total516516

@alperozturk96 alperozturk96 merged commit 3ce4b8b into master Aug 13, 2024
22 checks passed
@tobiasKaminsky tobiasKaminsky deleted the revert-13380-bugfix/empty-view-gravity-alignment branch October 7, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants