BugFix - OCShare Conversion #13519
BugFix - OCShare Conversion #13519
Conversation
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13519.apk |
There was a problem hiding this comment.
Unfortunately this change breaks the Shared tab in some use cases.
If the user doesn't have any shared files in the root directory, the tab will be stuck at Loading.... If there is a shared file in the root folder, this will indeed be displayed correctly. However, any files contained within subdirectories will not be displayed.
| shares.add(ocShare); | ||
|
|
||
| OCFile file = mStorageManager.getFileByDecryptedRemotePath(ocShare.getPath()); | ||
| if (file != null && file.getParentId() == currentRootDirId) { |
There was a problem hiding this comment.
As parseShares() is only called once, currentRootDirId will only be set once. This means that only files directly located within in root directory will show up in the Shared tab.
| @@ -547,6 +547,10 @@ public String getParentRemotePath() { | |||
| } | |||
| } | |||
|
|
|||
| public boolean isVisibleInSharedTab() { | |||
| return isSharedWithMe() || isSharedWithSharee() || isSharedViaLink() || isFolder(); | |||
There was a problem hiding this comment.
Due to the inclusion of isFolder() all folders will be shown.
Strangely, this doesn't seem to affect the actual result.
|
nextcloud/server#4456 API needs to be updated. This solution will solve the problem for only existing Files in device. When the device doesn't initially have an OCFile, the path can't be used to retrieve it. e.g. Shared file can be in a/b/c/d/a.txt --> to display a.txt in shared tab device must have OCFile. In first launch, app doesn't aware of that file and that file can be accessible when user enters the exact same path. |
Problem?
Solution