Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify FileDisplayActivity onBackPressed #13624

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Sep 25, 2024

  • Tests written, or not not needed

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13624.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Copy link

github-actions bot commented Oct 1, 2024

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6363
Dodgy code296296
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total509509

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 26.55%. Comparing base (cd716b2) to head (b057344).
Report is 59 commits behind head on master.

Files with missing lines Patch % Lines
...cloud/android/ui/activity/FileDisplayActivity.java 14.28% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13624      +/-   ##
============================================
+ Coverage     26.44%   26.55%   +0.10%     
- Complexity     3446     3477      +31     
============================================
  Files           674      674              
  Lines         49064    49258     +194     
  Branches       6562     6634      +72     
============================================
+ Hits          12977    13078     +101     
- Misses        34089    34170      +81     
- Partials       1998     2010      +12     
Files with missing lines Coverage Δ
...cloud/android/ui/activity/FileDisplayActivity.java 28.94% <14.28%> (-0.32%) ⬇️

... and 17 files with indirect coverage changes

@alperozturk96 alperozturk96 merged commit ff3a3bf into master Oct 7, 2024
22 of 23 checks passed
@alperozturk96 alperozturk96 deleted the simplify-on-back-pressed-logic branch October 7, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants