Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependency & Fix UI - Assistant Screen #13664

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 1, 2024

  • Tests written, or not not needed

Changes

  • Fix wrong color usages
  • Update code according to the latest dependency

Demo

test_assisntant.mp4

renovate bot and others added 4 commits October 2, 2024 09:03
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Copy link

github-actions bot commented Oct 2, 2024

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6363
Dodgy code296296
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total509509

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 26.42%. Comparing base (edb2a4a) to head (5056428).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...com/nextcloud/client/assistant/AsssistantScreen.kt 0.00% 14 Missing ⚠️
...ient/assistant/taskDetail/TaskDetailBottomSheet.kt 0.00% 8 Missing ⚠️
...m/nextcloud/client/assistant/AssistantViewModel.kt 0.00% 7 Missing ⚠️
...composeComponents/alertDialog/SimpleAlertDialog.kt 0.00% 4 Missing ⚠️
...nextcloud/client/assistant/component/CenterText.kt 0.00% 2 Missing ⚠️
.../owncloud/android/ui/activity/ToolbarActivity.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13664       +/-   ##
=============================================
+ Coverage          0   26.42%   +26.42%     
- Complexity        0     3455     +3455     
=============================================
  Files             0      674      +674     
  Lines             0    49157    +49157     
  Branches          0     6579     +6579     
=============================================
+ Hits              0    12991    +12991     
- Misses            0    34173    +34173     
- Partials          0     1993     +1993     
Files with missing lines Coverage Δ
...nextcloud/client/assistant/component/CenterText.kt 0.00% <0.00%> (ø)
.../owncloud/android/ui/activity/ToolbarActivity.java 57.75% <0.00%> (ø)
...composeComponents/alertDialog/SimpleAlertDialog.kt 0.00% <0.00%> (ø)
...m/nextcloud/client/assistant/AssistantViewModel.kt 0.00% <0.00%> (ø)
...ient/assistant/taskDetail/TaskDetailBottomSheet.kt 0.00% <0.00%> (ø)
...com/nextcloud/client/assistant/AsssistantScreen.kt 0.00% <0.00%> (ø)

... and 668 files with indirect coverage changes

@AndyScherzinger
Copy link
Member

Looks good to me, just as a general comment, we should be using the outlined style on input elements, as that is the standard we are aiming for

@tobiasKaminsky tobiasKaminsky merged commit 0801284 into master Oct 4, 2024
23 checks passed
@tobiasKaminsky tobiasKaminsky deleted the bugfix/assistant-screen branch October 4, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants