Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Power saving crash #14002

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Power saving crash #14002

merged 3 commits into from
Nov 25, 2024

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Nov 12, 2024 •
edited by alperozturk96
Loading

Fix #13404

  • Tests written, or not not needed

alperozturk96
alperozturk96 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working

@tobiasKaminsky @alperozturk96
Fix power check dialog
d763717 
added test

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @alperozturk96
Fix power check dialog
03b83c4 
added test

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky @alperozturk96
update screenshots
8512212 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code298298
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total508508

@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14002-Screenshot-blue-Light-15-37

@tobiasKaminsky tobiasKaminsky merged commit 287203e into master Nov 25, 2024
18 of 21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the powerSavingCrash branch November 25, 2024 13:24
@joshtrichards
Copy link
Member

Should we backport this to 3.30.x or is 3.30.6 the end of the line for 3.30.x?

@CodeSteph
Copy link

Should we backport this to 3.30.x or is 3.30.6 the end of the line for 3.30.x?

Yes please, this bug is very annoying. Can someone review it ?
It is blocking auto-upload for already selected directories and I haven't found any workaround to reactivate it (deselecting/reselecting, changing config, ...). Manually disabling power saving is not working either, thus, no more auto-upload for me. Please help, I'm convinced many users encounter the same issue

@tobiasKaminsky
Copy link
Member Author

Good idea 👍

@tobiasKaminsky
Copy link
Member Author

/backport to stable-3.30

@tobiasKaminsky
Copy link
Member Author

We will then release a new version on monday.

@backportbot backportbot bot mentioned this pull request Jan 3, 2025
Merged
This was referenced Jan 6, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 6, 2025
Closed
Closed
@ZetaTom ZetaTom mentioned this pull request Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperozturk96 alperozturk96 alperozturk96 approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
4 participants
@tobiasKaminsky @joshtrichards @CodeSteph @alperozturk96