BugFix - Icon Visibilities

[alperozturk96]

• Tests written, or not not needed

• Hide the people icon after sharing with at least one user (resolves share icon visibility issues).
• Use correct overlay icons for folders (e.g., shared with users, shared via link, locked, encrypted).
• Add offline operation folder type to screenshot tests.
• Fix and update broken screenshot tests.

Before	After

Folders With Overlay Icon

[AndyScherzinger]

Screenshot Tests look good to me. Just replace the existing ones with the new ones. They are visually similar but fail due to the update of the common lib which has m3 theming so the blue and Grey tones are slightly different now 👍

[AndyScherzinger]

LGTM

@alperozturk96 As a follow up maybe, did you see that the folder icons with an overlay are slightly smaller see their width than folders without an overlay? 🔍

[alperozturk96]

@AndyScherzinger Thank you. Good point. I will update the PR.

[ZetaTom]

During my testing I've noticed some inconsistencies compared to the previous implementation. Otherwise it seems to work as expected; the share icon is only displayed when expected.

1. Corners of thumbnails are no longer rounded (see screenshot below)
2. Thumbnails of images are only displayed after a manual reload (pull to refresh)
3. The ic_movie overlay for video files is scaled wrong (see screenshot below)
4. Appearance of auto-upload folder has changed (icon used to be taller)

[alperozturk96]

During my testing I've noticed some inconsistencies compared to the previous implementation. Otherwise it seems to work as expected; the share icon is only displayed when expected.

1. Corners of thumbnails are no longer rounded (see screenshot below)

2. Thumbnails of images are only displayed after a manual reload (pull to refresh)

3. The `ic_movie` overlay for video files is scaled wrong (see screenshot below)

4. Appearance of auto-upload folder has changed (icon used to be taller)

I uploaded the image and got a preview immediately. I’m unable to reproduce the second issue. Is it the same on the master branch? If not, could you provide a video recording so I can attempt to reproduce it?

Demo for thumbnail

thumn.mp4

The appearance of all folder overlay icons has changed due to updated logic. The width of overlayed icons was not the same as non-overlayed icons. With this PR, the widths are now consistent, which will affect the appearance.

For mentioned other issues, I updated the PR.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	59	59
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	65	65
Correctness	58	58
Dodgy code	298	298
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	1	1
Multithreaded correctness	7	7
Performance	53	53
Security	18	18
Total	508	508

[jancborchardt]

Just a small thing – the avatar seems to be a bit off to the right compared to the sharing icons. Not super important but might be easy to fix?

[tobiasKaminsky]

Just a small thing – the avatar seems to be a bit off to the right compared to the sharing icons. Not super important but might be easy to fix?

Will be done in a new PR.