ToS #14159
ToS #14159
Conversation
|
test-Unit test failed, but no output was generated. Maybe a preliminary stage failed. |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
| @@ -1423,6 +1441,91 @@ public void onReceive(Context context, Intent intent) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| private void showDialog() { | |||
There was a problem hiding this comment.
The current logic can be moved into a new DialogFragment or class for better separation of concerns, maintainability and code readability. Now, one single function does multiple things and hard to read code.
New Class:
• showDialog(): Display the dialog when necessary.
• private getTerms(): Fetch the terms.
• private signTerms(): Handle the logic for signing the terms.
• private setLanguageDropdown(): Manage the language dropdown setup and selection.
...more functions if it's necessary
FileDisplayActivity will call showDialog() function. If it's necessary it will display dialog, else it will do nothing.
| @@ -10,7 +10,7 @@ | |||
| */ | |||
| buildscript { | |||
| ext { | |||
| androidLibraryVersion ="4a95888afc472369e85fccae3d3573ff9e36fb50" | |||
| androidLibraryVersion ="f21604054b" | |||
There was a problem hiding this comment.
When I was trying to test I came across with dependency verification error.
Needs: nextcloud/android-library#1604