Skip to content

Improve color theming and general layouting #16259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alperozturk96 merged 1 commit into from
Jan 12, 2026
Merged

Improve color theming and general layouting #16259

alperozturk96 merged 1 commit into from
Jan 12, 2026

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Jan 8, 2026 •
edited
Loading

Resolves #16245 plus enhances the sharing layout/theming in general

🖼️ Screenshots

🏚️ Before 🏡 After
before after
  • Tests written, or not not needed

@AndyScherzinger AndyScherzinger changed the title fix(theming): Improve color theming and general layouting Improve color theming and general layouting Jan 8, 2026
@AndyScherzinger AndyScherzinger force-pushed the fix/16245/improveThemingAndLayouting branch from cd603f7 to 5119b5a Compare January 8, 2026 14:55
@AndyScherzinger AndyScherzinger force-pushed the fix/16245/improveThemingAndLayouting branch from 5119b5a to 47e11b9 Compare January 8, 2026 15:00
@AndyScherzinger AndyScherzinger mentioned this pull request Jan 8, 2026
Closed
4 tasks
@AndyScherzinger AndyScherzinger force-pushed the fix/16245/improveThemingAndLayouting branch 4 times, most recently from 56eae2c to 0531633 Compare January 9, 2026 15:10
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.36.0 milestone Jan 9, 2026
@AndyScherzinger AndyScherzinger force-pushed the fix/16245/improveThemingAndLayouting branch 2 times, most recently from 8428727 to 8c9cd50 Compare January 9, 2026 18:51
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code257257
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4444
Security1818
Total481481

@AndyScherzinger @alperozturk96
fix(theming): Improve color theming and general layouting
946b54f 
Resolves #16245

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@alperozturk96 alperozturk96 force-pushed the fix/16245/improveThemingAndLayouting branch from 8c9cd50 to 946b54f Compare January 12, 2026 12:38
alperozturk96
alperozturk96 approved these changes Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.

@alperozturk96 alperozturk96 merged commit c8469d6 into master Jan 12, 2026
16 of 20 checks passed
@alperozturk96 alperozturk96 deleted the fix/16245/improveThemingAndLayouting branch January 12, 2026 12:45
@github-actions
Copy link

github-actions bot commented Jan 12, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link

github-actions bot commented Jan 12, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16259.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alperozturk96 alperozturk96 alperozturk96 approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review design

Projects

None yet

Milestone

Nextcloud App 3.36.0

Development

Successfully merging this pull request may close these issues.

The colors of the three places are inconsistent with the color of the theme's accent color.

3 participants

@AndyScherzinger @alperozturk96