-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avatar Etags #1658
Avatar Etags #1658
Conversation
8d9becf
to
3ba3f9b
Compare
Once nextcloud/server#6876 is merged the problem should be solved as we then always have a bitmap. |
nextcloud/server#6876 is merged :) |
213ce41
to
35ac7eb
Compare
nextcloud/server#6876 is independent from this PR as it is NC13 only.
Annotated via custom annotation. The idea is that we can use this for tracking code parts which we can later remove. In this case, if min supported version is 13, we can safely delete this code. |
dae8b5d
to
82d2de1
Compare
Is this ready for review @tobiasKaminsky ? |
Yes. Do you want to have it in 2.1? |
Yes
…On Thu, 11 Jan 2018 at 11:47, Tobias Kaminsky ***@***.***> wrote:
Yes. Do you want to have it in 2.1?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1658 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAWskfR9Hkunx5DpAfSHFiE0RCRhqWTks5tJea6gaJpZM4P2iwS>
.
|
82d2de1
to
07b74b5
Compare
Then rebased and ready for review & test. |
d346f9d
to
614d78b
Compare
added one more annotation Signed-off-by: tobiaskaminsky <tobias@kaminsky.me>
Resolves #1566
This caches the etag of an avatar and sends the etag to server and gets
Edit: not query the server too often we could also implement a 15min timeout, or whatever time.