Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar Etags #1658

Merged
merged 5 commits into from
Jan 15, 2018
Merged

Avatar Etags #1658

merged 5 commits into from
Jan 15, 2018

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Oct 12, 2017

Resolves #1566

This caches the etag of an avatar and sends the etag to server and gets

  • a new avatar if etag changed -> use new one
  • a 304 response, meaning nothing changed -> show old avatar

Edit: not query the server too often we could also implement a 15min timeout, or whatever time.

@tobiasKaminsky
Copy link
Member Author

Once nextcloud/server#6876 is merged the problem should be solved as we then always have a bitmap.

@rullzer
Copy link
Member

rullzer commented Dec 20, 2017

nextcloud/server#6876 is merged :)

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Dec 21, 2017

nextcloud/server#6876 is independent from this PR as it is NC13 only.
Once NC13 is our oldest supported release we can remove

public static TextDrawable createAvatar(String accountName, float radiusInDp) throws

Annotated via custom annotation. The idea is that we can use this for tracking code parts which we can later remove. In this case, if min supported version is 13, we can safely delete this code.

@mario
Copy link
Contributor

mario commented Jan 11, 2018

Is this ready for review @tobiasKaminsky ?

@tobiasKaminsky
Copy link
Member Author

Yes. Do you want to have it in 2.1?

@mario
Copy link
Contributor

mario commented Jan 11, 2018 via email

@tobiasKaminsky
Copy link
Member Author

Then rebased and ready for review & test.

@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 2.1.0 milestone Jan 11, 2018
@tobiasKaminsky tobiasKaminsky force-pushed the avatarETags branch 3 times, most recently from d346f9d to 614d78b Compare January 15, 2018 07:40
@tobiasKaminsky tobiasKaminsky merged commit 8d63ef5 into master Jan 15, 2018
@tobiasKaminsky tobiasKaminsky deleted the avatarETags branch January 15, 2018 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants