Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific sort order for upload/local/trashbin #3205

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Conversation

tobiasKaminsky
Copy link
Member

Fix #2919

Trashbin: new->old by default

We previously had one setting for all three above. There is no good transition in my opinion, so it starts for upload/local a->z and trashbin: new->old

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #3205 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #3205      +/-   ##
===========================================
- Coverage      6.35%   6.35%   -0.01%     
  Complexity        1       1              
===========================================
  Files           310     310              
  Lines         30194   30237      +43     
  Branches       4320    4324       +4     
===========================================
+ Hits           1920    1921       +1     
- Misses        27989   28031      +42     
  Partials        285     285
Impacted Files Coverage Δ Complexity Δ
...om/owncloud/android/utils/FileSortOrderByDate.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...d/android/ui/preview/PreviewImagePagerAdapter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...cloud/android/ui/activity/UploadFilesActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../android/ui/dialog/SortingOrderDialogFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...om/owncloud/android/utils/FileSortOrderByName.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...om/owncloud/android/utils/FileSortOrderBySize.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...owncloud/android/ui/adapter/OCFileListAdapter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/com/owncloud/android/db/PreferenceManager.java 26.72% <0%> (-2.8%) 0 <0> (ø)
...owncloud/android/ui/trashbin/TrashbinActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...cloud/android/ui/activity/FileDisplayActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 10 more

trashbin: new->old by default

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Lint

TypeMasterPR
Warnings9797
Errors

FindBugs (new)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings165
Internationalization Warnings14
Malicious code vulnerability Warnings10
Multithreaded correctness Warnings9
Performance Warnings123
Security Warnings202
Dodgy code Warnings137
Total695

FindBugs (master)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings165
Internationalization Warnings14
Malicious code vulnerability Warnings10
Multithreaded correctness Warnings9
Performance Warnings123
Security Warnings202
Dodgy code Warnings137
Total695

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Nov 1, 2018

👍

Approved with PullApprove

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.4.0 milestone Nov 1, 2018
@AndyScherzinger AndyScherzinger merged commit c15bc58 into master Nov 1, 2018
@AndyScherzinger AndyScherzinger deleted the sortTrash branch November 1, 2018 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants