Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better way to colorize text #4193

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Better way to colorize text #4193

merged 1 commit into from
Jul 1, 2019

Conversation

tobiasKaminsky
Copy link
Member

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@tobiasKaminsky
better way to colorize text
c8d9a79 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Copy link
Member Author

/backport to stable-3.7

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9862.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/9862

@nextcloud-android-bot
Copy link
Collaborator

Codacy

306

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings68
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings137
Total422

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings68
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings137
Total422

@tobiasKaminsky
Copy link
Member Author

IT test failed: kaminsky.me/nc-dev/android-integrationTests/9862

Unrelated, will check tomorrow.

@tobiasKaminsky tobiasKaminsky merged commit 0fc092a into master Jul 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the colorizeText branch July 1, 2019 14:34
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 1, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable-3.7 in #4195

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.8.0 milestone Jul 1, 2019
tobiasKaminsky added a commit that referenced this pull request Jul 2, 2019
@tobiasKaminsky
daily dev 20190702
0a10bc0 
0fc092a Better way to colorize text (#4193)
49d038d npe in file owner after upgrade (#4191)
c8d9a79 better way to colorize text
b5e69db npe in file owner after upgrade
3a7755e daily dev 20190701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasKaminsky @nextcloud-android-bot @AndyScherzinger