Allow whole folders to be uploaded to the server

[robb4]

Long press the folder to select it
Refs: #184

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10924.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[tobiasKaminsky]

Instead of adding a non-visible long press action, I would simply use the multiple choice checkbox for this.

[robb4]

Hmm, your screeshot looks a bit off, this is how it looks for me:

Currently, for files, the checkbox gets activated by a single tap, but a tap on a folder navigates to it's content. It would make a bit more sense UX-wise to select both types on a tap, but that would interfere with the current behaviour. Is it acceptable to change the navigation option to a long tap?

[tobiasKaminsky]

Sorry, I somehow was on the wrong branch.
Adding long press is something no user will directly know/understand, so I think we can omit it.
Having a checkbox for a folder should be enough @jancborchardt?

[tobiasKaminsky]

@robb4 thanks for contributing to this long wished feature 🎉

[tobiasKaminsky]

I created such a folder structure

• 1
• 1/2
• 1/2a
• 1/2/test.pdf

and select 1 to be uploaded, but "only":

• 1/2/test.pdf was uploaded
  Empty 2a was not created.
  I guess it as we only upload files.
  I fear that people expect that also empty folders are created, which then unfortunately complicates it a lot…

[robb4]

@tobiasKaminsky it does indeed only upload files, and it does not create empty folders. I'll take a look over this use-case when I'll have some free time.

[jancborchardt]

Sorry for the late reply – yes the checkbox seems good to select folders! 👍

@robb4 any update on the other parts? :)

[robb4]

@jancborchardt Sadly I haven't had the time to work on this lately.
I was initially hoping that creating empty folders too would be a quick and easy fix, but at a closer look it showed to be a bit more problematic.
I tried piggybacking off the 'Create Folder' action available in the same activity, but that got messy quickly, so last time I was investigating different solutions to this. I could probably use some hints from someone who's more familiar to the architecture :)
I hope to be able to get back to this in the following weeks.

[kilves]

@robb4 Are you still working on this? I accidently started this issue without even noticing that it had been under development for a few months already. I also completely missed the parameter on requester.uploadNewFile() that allows you to auto-create folders, so I ended up implementing my own folder creation. My redundant-but-useful solution might be of some help: kilves@0297601 the folder creation code here could probably be adapted to also create empty folders with just a few lines of extra code.

There's also a $300 bounty on this in bountysource if you're interested in splitting it: https://www.bountysource.com/issues/36543232-upload-whole-folder

[robb4]

@kilves No, I haven't really worked on the core issue with my PR (the empty folders part), I only have a few local changes like not using long press to select and some other messed up code written while investigating.
To be honest, if your solution already ticks all the requirements go for it and raise a PR. If it's not complete and you think I can help you with something then sure, drop me a line on IRC or something and we can collaborate, but from what I've looked over your code I don't believe there's any benefit of merging the two solutions together.

[AndyScherzinger]

superseeded by #7877