Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused dependencies #4731

Merged
merged 1 commit into from
Oct 25, 2019
Merged

remove unused dependencies #4731

merged 1 commit into from
Oct 25, 2019

Conversation

AndyScherzinger
Copy link
Member

removed markdown dependencies for features we currently don't use/support

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11401.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

304

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings68
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total420

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings68
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total420

@tobiasKaminsky tobiasKaminsky merged commit ea77b44 into master Oct 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the markdownPreview_cleanup branch October 25, 2019 07:57
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.9.0 milestone Oct 25, 2019
@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #4731 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4731      +/-   ##
============================================
+ Coverage     17.49%   17.49%   +<.01%     
  Complexity        3        3              
============================================
  Files           374      374              
  Lines         32212    32212              
  Branches       4549     4549              
============================================
+ Hits           5635     5636       +1     
+ Misses        25670    25658      -12     
- Partials        907      918      +11
Impacted Files Coverage Δ Complexity Δ
.../third_parties/daveKoeller/AlphanumComparator.java 80.95% <0%> (-1.2%) 0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java 22.22% <0%> (-0.57%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 20.49% <0%> (+0.32%) 0% <0%> (ø) ⬇️

tobiasKaminsky added a commit that referenced this pull request Oct 26, 2019
4f8fc49 Merge pull request #4730 from nextcloud/taskTwice
ea77b44 Merge pull request #4731 from nextcloud/markdownPreview_cleanup
1ecd563 remove unused dependencies
0444d07 Merge pull request #4728 from nextcloud/markdownPreview_Theming
44fefe9 fix notification task, if it failed first
5ec79a9 [tx-robot] updated from transifex
01c480f daily dev 20191025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants