Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing picture "set as wallpaper" issue in properties (duplicate) #4801

Conversation

Kilian-Perisset
Copy link
Member

(created from #4795) based on issue : #4764

Hi,

Despite the existence of sign-offs on the other branch commits, does not want to accept this branch 😭

So here is a new branch, with signed commits and verified origin.
Sorry for the duplication

Signed-off-by: Kilian Périsset kilian.perisset@infomaniak.com

Signed-off-by: Kilian Périsset <kilian.perisset@infomaniak.com>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11547.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

304

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total423

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings138
Total423

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #4801 into master will increase coverage by 0.03%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4801      +/-   ##
============================================
+ Coverage     17.48%   17.51%   +0.03%     
  Complexity        3        3              
============================================
  Files           376      376              
  Lines         32385    32387       +2     
  Branches       4569     4569              
============================================
+ Hits           5661     5673      +12     
+ Misses        25813    25795      -18     
- Partials        911      919       +8
Impacted Files Coverage Δ Complexity Δ
...ncloud/android/ui/fragment/FileDetailFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/com/owncloud/android/ui/SquareLinearLayout.java 0% <0%> (-50%) 0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java 29% <0%> (-0.77%) 0% <0%> (ø)
...ncloud/android/ui/fragment/OCFileListFragment.java 25.3% <0%> (-0.68%) 0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java 22.79% <0%> (ø) 0% <0%> (ø) ⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java 35.76% <0%> (+0.18%) 0% <0%> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0%> (+1.19%) 0% <0%> (ø) ⬇️
.../java/com/owncloud/android/utils/DisplayUtils.java 24.89% <0%> (+1.26%) 0% <0%> (ø) ⬇️
...in/java/com/owncloud/android/utils/ThemeUtils.java 51.57% <0%> (+1.96%) 0% <0%> (ø) ⬇️
...m/owncloud/android/ui/activity/DrawerActivity.java 45.19% <0%> (+2.29%) 0% <0%> (ø) ⬇️

@tobiasKaminsky
Copy link
Member

/backport to stable-3.9

@tobiasKaminsky tobiasKaminsky merged commit 180bdee into nextcloud:master Nov 6, 2019
@tobiasKaminsky
Copy link
Member

@Shagequi thanks for your PR 🎉

@backportbot-nextcloud
Copy link

backport to stable-3.9 in #4803

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.10.0 milestone Nov 6, 2019
@Kilian-Perisset Kilian-Perisset deleted the feature/resolve-set-as-wallpaper-issue branch November 6, 2019 14:19
tobiasKaminsky added a commit that referenced this pull request Nov 7, 2019
890789f Merge pull request #4797 from nextcloud/ezaquarii/replace-shared-preferences-with-app-preferences-in-base-activity
180bdee Merge pull request #4801 from Infomaniak/feature/resolve-set-as-wallpaper-issue
039adc0 [tx-robot] updated from transifex
b59938d daily dev 20191106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants