-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing picture "set as wallpaper" issue in properties (duplicate) #4801
Merged
tobiasKaminsky
merged 1 commit into
nextcloud:master
from
Infomaniak:feature/resolve-set-as-wallpaper-issue
Nov 6, 2019
Merged
Fixing picture "set as wallpaper" issue in properties (duplicate) #4801
tobiasKaminsky
merged 1 commit into
nextcloud:master
from
Infomaniak:feature/resolve-set-as-wallpaper-issue
Nov 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kilian Périsset <kilian.perisset@infomaniak.com>
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11547.apk |
Codacy304Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #4801 +/- ##
============================================
+ Coverage 17.48% 17.51% +0.03%
Complexity 3 3
============================================
Files 376 376
Lines 32385 32387 +2
Branches 4569 4569
============================================
+ Hits 5661 5673 +12
+ Misses 25813 25795 -18
- Partials 911 919 +8
|
AndyScherzinger
approved these changes
Nov 5, 2019
/backport to stable-3.9 |
@Shagequi thanks for your PR 🎉 |
backport to stable-3.9 in #4803 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created from #4795) based on issue : #4764
Hi,
Despite the existence of sign-offs on the other branch commits, does not want to accept this branch 😭
So here is a new branch, with signed commits and verified origin.
Sorry for the duplication
Signed-off-by: Kilian Périsset kilian.perisset@infomaniak.com