Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots: shorten text a bit #4858

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Screenshots: shorten text a bit #4858

merged 1 commit into from
Nov 19, 2019

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Nov 19, 2019

Fix: #4840
Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Copy link
Member Author

I will wait until next release 3.10 to get translations up to date and then re-run screenshots.

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11668.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

306

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings136
Total422

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings119
Security Warnings44
Dodgy code Warnings136
Total422

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #4858 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4858      +/-   ##
============================================
+ Coverage      17.6%   17.62%   +0.01%     
  Complexity        3        3              
============================================
  Files           377      377              
  Lines         32403    32403              
  Branches       4580     4580              
============================================
+ Hits           5704     5710       +6     
+ Misses        25784    25777       -7     
- Partials        915      916       +1
Impacted Files Coverage Δ Complexity Δ
...va/com/owncloud/android/ui/SquareLinearLayout.java 0% <0%> (-50%) 0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java 29% <0%> (-0.58%) 0% <0%> (ø)
...ncloud/android/ui/fragment/OCFileListFragment.java 25.3% <0%> (-0.28%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 19.91% <0%> (-0.09%) 0% <0%> (ø)
...oud/android/operations/RefreshFolderOperation.java 57.39% <0%> (+0.43%) 0% <0%> (ø) ⬇️
...oud/android/ui/activity/SyncedFoldersActivity.java 23.97% <0%> (+0.58%) 0% <0%> (ø) ⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java 35.76% <0%> (+0.72%) 0% <0%> (ø) ⬇️
.../java/com/owncloud/android/utils/DisplayUtils.java 24.89% <0%> (+1.26%) 0% <0%> (ø) ⬇️
...in/java/com/owncloud/android/utils/ThemeUtils.java 51.57% <0%> (+1.57%) 0% <0%> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 83.33% <0%> (+2.38%) 0% <0%> (ø) ⬇️

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@AndyScherzinger AndyScherzinger merged commit 21ef006 into master Nov 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the changeScreenshot branch November 19, 2019 16:45
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.10.0 milestone Nov 19, 2019
tobiasKaminsky added a commit that referenced this pull request Nov 20, 2019
21ef006 Merge pull request #4858 from nextcloud/changeScreenshot
0223085 shorten text a bit
8879179 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
94502f6 Merge pull request #4787 from ArisuOngaku/auto-upload-start-date-persistence
2110937 Merge pull request #4839 from nextcloud/dependabot/gradle/markwonVersion-4.2.0
f1a0ac5 [tx-robot] updated from transifex
a00677c daily dev 20191119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screenshots' text too long
4 participants