Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use android test orchestrator #4932

Merged
merged 2 commits into from
Dec 12, 2019
Merged

Use android test orchestrator #4932

merged 2 commits into from
Dec 12, 2019

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Dec 4, 2019

This should make it a bit more robust, e.g. no context is shared between different tests and if one test fails the other will still be executed.

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@nextcloud-android-bot
Copy link
Collaborator

@AndyScherzinger
Copy link
Member

@tobiasKaminsky needs a rebase and see #4932 (comment) tests are reported to be failing but aren't 😁

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11964.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

327

Lint

TypemasterPR
Warnings7373
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings106
Security Warnings44
Dodgy code Warnings136
Total409

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings106
Security Warnings44
Dodgy code Warnings136
Total409

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #4932 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4932      +/-   ##
============================================
- Coverage     17.78%   17.62%   -0.16%     
  Complexity        3        3              
============================================
  Files           385      385              
  Lines         32675    32675              
  Branches       4593     4593              
============================================
- Hits           5810     5759      -51     
- Misses        25940    25987      +47     
- Partials        925      929       +4
Impacted Files Coverage Δ Complexity Δ
...services/firebase/NCFirebaseInstanceIDService.java 62.5% <0%> (-25%) 0% <0%> (ø)
...com/owncloud/android/datastorage/StoragePoint.java 66.66% <0%> (-16.67%) 0% <0%> (ø)
src/main/java/com/owncloud/android/MainApp.java 49.25% <0%> (-6.87%) 0% <0%> (ø)
...xtcloud/client/preferences/AppPreferencesImpl.java 52.43% <0%> (-5.95%) 0% <0%> (ø)
...va/com/owncloud/android/utils/FilesSyncHelper.java 19.1% <0%> (-3.38%) 0% <0%> (ø)
...ncloud/android/datamodel/SyncedFolderProvider.java 8.33% <0%> (-3.34%) 0% <0%> (ø)
...wncloud/android/providers/FileContentProvider.java 18.5% <0%> (-3.11%) 0% <0%> (ø)
...om/owncloud/android/utils/FileSortOrderByName.java 14.28% <0%> (-2.86%) 0% <0%> (ø)
...in/java/com/owncloud/android/datamodel/OCFile.java 65.31% <0%> (-1.81%) 0% <0%> (ø)
...in/java/com/owncloud/android/utils/ThemeUtils.java 49.41% <0%> (-1.56%) 0% <0%> (ø)
... and 15 more

@AndyScherzinger AndyScherzinger merged commit 10789e9 into master Dec 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the useTestOrchestrator branch December 12, 2019 12:05
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.10.0 milestone Dec 12, 2019
tobiasKaminsky added a commit that referenced this pull request Dec 13, 2019
10789e9 Merge pull request #4932 from nextcloud/useTestOrchestrator
50a73b4 on smaller displays we have to swipe up
9fce154 Use android test orchestrator
cbf59eb Merge pull request #4983 from nextcloud/disableGoogleTracking
e8eae2a disable google test tracking
257ac81 Merge pull request #4900 from nextcloud/v2withActivity
a235718 fix tests
6eb4ac7 revert to master snapshot
8b61e74 remove unneeded accountManager
e5cd5ff use nextcloudClient.execute(…)
066f4c2 Initial work on v2 with activity
45f1146 [tx-robot] updated from transifex
d913950 daily dev 20191211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants