Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont dismiss notification after each upload/download #7949

Merged
merged 4 commits into from
Feb 24, 2021
Merged

Dont dismiss notification after each upload/download #7949

merged 4 commits into from
Feb 24, 2021

Conversation

newhinton
Copy link
Contributor

@newhinton newhinton commented Feb 7, 2021 •
edited
Loading

  • Tests written, or not not needed (I don't think they are needed here, please correct me if im wrong)

This PR aims to 'group' notifications for transfer-progress together so that they are not obstrusive. Instead of recreating each notification (and therefore create distracting effects in the notifcation area of android) the existing notification is reused and just updated.

Also no additional 'success'-message is beeing shown, only errors are displayed. Each error has it's own id, so that they are preserved after the upload. This applies to 'normal' up and downloads. Instant-Upload acts slightly different and cannot use this change to the full extend.

Closes #7651

@nextcloud-android-bot
Copy link
Collaborator

Blue-Light-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7949-Screenshot-Blue-Light-21-19

@tobiasKaminsky
Copy link
Member

@newhinton tested and works 👍
Great work!

Can you rebase it and have a look at spotbugs? There seem to be some more warnings coming with this PR.

@AndyScherzinger
Copy link
Member

❗ REBASED ❗

...since Spotbugs results are deleted (housekeepign) so trigger run again based on latest master @newhinton

@AndyScherzinger
Copy link
Member

Spotbugs should be resolved with the latest commit, let's see what CI is thinking of it :)

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/7949.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/7949.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/763-IT-master-15-19

@nextcloud-android-bot
Copy link
Collaborator

Blue-Dark-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7949-Screenshot-Blue-Dark-15-19

@nextcloud-android-bot
Copy link
Collaborator

White-Dark-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7949-Screenshot-White-Dark-15-19

@nextcloud-android-bot
Copy link
Collaborator

Blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7949-Screenshot-Blue-Light-15-32

@nextcloud-android-bot
Copy link
Collaborator

White-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7949-Screenshot-White-Light-15-28

newhinton and others added 4 commits February 24, 2021 11:55
@newhinton @AndyScherzinger
Dont dismiss notification after each upload/download
4c77c6a 
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
@AndyScherzinger
replace Random with SecureRandom and ignore Spotbugs warnign about ra…
8bf657c 
…ndomness (just creating Notification IDs)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
Update screenshots
debc206 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
format code
9e2920b 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger merged commit 09cead8 into master Feb 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/7651/singlenotification branch February 24, 2021 10:56
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.16.0 milestone Feb 24, 2021
@nextcloud-android-bot
Copy link
Collaborator

Codacy

Lint

TypemasterPR
Warnings232232
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings52
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings73
Security Warnings40
Dodgy code Warnings99
Total309

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings52
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings73
Security Warnings40
Dodgy code Warnings99
Total309

@nextcloud-android-bot
Copy link
Collaborator

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/819-IT-stable-11-17

@AndyScherzinger AndyScherzinger mentioned this pull request Mar 17, 2021
Closed
@AndyScherzinger AndyScherzinger mentioned this pull request May 17, 2021
Closed
@wknds wknds mentioned this pull request Sep 29, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.16.0
Development

Successfully merging this pull request may close these issues.

Use a single notification when downloading (syncing) an entire folder
4 participants
@newhinton @nextcloud-android-bot @tobiasKaminsky @AndyScherzinger