Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.16] dismiss only after delay to remove stuck notification #8189

Merged
merged 1 commit into from
Mar 19, 2021
Merged

[stable-3.16] dismiss only after delay to remove stuck notification #8189

merged 1 commit into from
Mar 19, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #8187

@newhinton @backportbot
dismiss only after delay to remove stuck notification
847bab6 
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud App 3.16.0 milestone Mar 18, 2021
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/8189.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1084-IT-master-20-37

@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-3.16PR
Warnings232232
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings51
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings73
Security Warnings40
Dodgy code Warnings98
Total307

SpotBugs (stable-3.16)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings51
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings73
Security Warnings40
Dodgy code Warnings98
Total307

@tobiasKaminsky tobiasKaminsky merged commit ede5a60 into stable-3.16 Mar 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the backport/8187/stable-3.16 branch March 19, 2021 12:09
@tobiasKaminsky tobiasKaminsky mentioned this pull request Apr 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@newhinton newhinton Awaiting requested review from newhinton

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud App 3.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nextcloud-android-bot @AndyScherzinger @tobiasKaminsky @newhinton