Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old reference to onClick, this is now handled via ButterKnife #993

Merged
merged 3 commits into from
May 13, 2017
Merged

remove old reference to onClick, this is now handled via ButterKnife #993

merged 3 commits into from
May 13, 2017

Conversation

tobiasKaminsky
Copy link
Member

use "end" instead of "right" for RTL support

@AndyScherzinger
Copy link
Member

AndyScherzinger commented May 13, 2017 •
edited
Loading

👍 Looking good :)

Approved with PullApprove

@mario
Copy link
Contributor

mario commented May 13, 2017

Looks good, but build fails?

@AndyScherzinger
Copy link
Member

AndyScherzinger commented May 13, 2017 •
edited
Loading

👍 rebased and rerun, @mario please re-approve and merge

Approved with PullApprove

@mario
Copy link
Contributor

mario commented May 13, 2017 •
edited by AndyScherzinger
Loading

👍

Approved with PullApprove

@mario mario merged commit 01fc8ab into master May 13, 2017
@mario mario deleted the contactButton branch May 13, 2017 20:58
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 1.5.0 milestone May 13, 2017
@thsnielsen thsnielsen mentioned this pull request Jun 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud App 2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasKaminsky @AndyScherzinger @mario