copy SSL certificates from NC instance to ExApp upon install/update action #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
|
the only thing that worries me is that we copy all the certificates from the bundle from the server, including the system ones. as far as I know, this shouldn't break anything, and this PR won't be backported, so we have plenty of time for testing until Nextcloud 31 get released. |
kyteinsky
reviewed
Nov 21, 2024
kyteinsky
reviewed
Nov 21, 2024
Comment on lines
+151
to
+152
| // Build the path in the container | ||
| $pathInContainer = $targetDir . "/custom_cert_$index.crt"; |
There was a problem hiding this comment.
we can probably have the same filename for easy manual removal/addition? So the filename of the original cert instead of $index. What do you say?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
updateCertificatesmethod to automate SSL certificate updates in Docker containers.It detects the container's OS, determines the correct certificate directory (e.g.,
/usr/local/share/ca-certificatesfor Debian), parses the Nextcloud certificate bundle, copies individual certificates into the container, and applies updates using OS-specific commands likeupdate-ca-certificates.Tested on Debian and Alpine.