Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(initial-state): correct defaultDaemonConfig initial state #473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(initial-state): correct defaultDaemonConfig initial state #473

wants to merge 1 commit into from
+3 −1

Conversation

andrey18106
Copy link
Collaborator

There is was missing check if no deploy daemons configured, null value produced warning logs.

Resolves: #472

@andrey18106
fix(initial-state): correct defaultDaemonConfig initial state
bd447b8 
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@andrey18106 andrey18106 requested a review from bigcat88 December 17, 2024 14:43
@andrey18106
Copy link
Collaborator Author

/backport to stable30

oleksandr-nc
oleksandr-nc approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@oleksandr-nc oleksandr-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I hope the frontend will handle the missing defaultDaemonConfig correctly

Don't forget to increase the version in a separate PR, for the stable30 branch, so that it is the same minor as the server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-nc oleksandr-nc oleksandr-nc approved these changes

@bigcat88 bigcat88 Awaiting requested review from bigcat88

Assignees
No one assigned
Labels
backport-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Warning message in log (defaultDaemonConfig) when navigating to "Applications" tab and submenu
2 participants
@andrey18106 @oleksandr-nc