Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ dashboard/widget #567

Merged
merged 4 commits into from
Oct 18, 2018
Merged

+ dashboard/widget #567

merged 4 commits into from
Oct 18, 2018

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Jul 17, 2018

add

<dashboard>
  <widget>PhpClass</widget>
</dashboard>

However, not sure those changes are enough !

@coveralls
Copy link

coveralls commented Jul 17, 2018

Coverage Status

Coverage increased (+0.001%) to 97.56% when pulling 4a83b02 on dashboard into c8c3429 on master.

@BernhardPosselt
Copy link
Member

Hi @daita

Not sure if we should fill up an apps info.xml with meta information for other apps. This makes future development harder for the server (e.g. think about nextcloud adding a dashboard default app and wanting to use the same tag).

I suppose your use case is adding/fetching dashboard plugins correct? In that case, why don't you use something different than the info.xml file? There are so many ways like dropping a file in a certain path (e.g. lib/Dashboard/Plugin.php) or use the database to register plugins.

@ArtificialOwl
Copy link
Member Author

Well, this is supposed to be the nextcloud dashboard default app.

I will check with the @nextcloud/designers for other solutions.

@BernhardPosselt
Copy link
Member

Maybe ask Morris or joas what they think of it.

@ArtificialOwl
Copy link
Member Author

@MorrisJobke - please halp :)

Branch: https://github.com/nextcloud/dashboard/tree/gridstack
PR on server: nextcloud/server#10222
Widgets on their way: nextcloud/dashboard#39

Could be great to have this for NC14.

@MorrisJobke
Copy link
Member

Could be great to have this for NC14.

It's a bit late for that ... freeze was on Friday ... at least for the server PR.

@MorrisJobke
Copy link
Member

As written in the server ticket: let's aim for the Nextcloud 15 release.

@BernhardPosselt
Copy link
Member

Do we want to add extra tags for non core apps as well? Maybe makes sense to add a non schema validated section like:

<meta>
    <! -- all elements here allowed here using https://www.w3schools.com/XML/schema_complex_any.asp -->
</meta>

So OP could add

<meta app="dashboard">
    <widget>PhpClass</widget>
</meta>

But I think using a file name by convention or storing the setting in the database is ultimately a better idea because OP can simply query the database or include a file if it exists without having to parse all app's xml again (given that the server does not persist this on install)

@ArtificialOwl
Copy link
Member Author

@BernhardPosselt @MorrisJobke

What about this PR, now that the interface for the dashboard are in the core of Nextcloud ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants