Skip to content

Commit

Permalink
Add Nextcloud 25 support on master
Browse files Browse the repository at this point in the history
Signed-off-by: Joas Schilling <coding@schilljs.com>
  • Loading branch information
nickvergessen committed Sep 22, 2022
1 parent 74a15dd commit 4135ac5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions appinfo/info.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ bruteforce protected controller with the same API slower for a 24 hour period.
With this app, the admin can exempt an IP address or range from this
protection which can be useful for testing purposes or when there are false
positives due to a lot of users on one IP address.]]></description>
<version>2.5.0</version>
<version>2.6.0</version>
<licence>agpl</licence>
<author>Roeland Jago Douma</author>
<namespace>BruteForceSettings</namespace>
Expand All @@ -25,7 +25,7 @@ positives due to a lot of users on one IP address.]]></description>
<repository type="git">https://github.com/nextcloud/bruteforcesettings.git</repository>
<screenshot>https://raw.githubusercontent.com/nextcloud/bruteforcesettings/master/screenshots/1.png</screenshot>
<dependencies>
<nextcloud min-version="21" max-version="25" />
<nextcloud min-version="26" max-version="26" />

This comment has been minimized.

Copy link
@vipergts450

vipergts450 Oct 24, 2022

Is this change breaking compatibility with NC25? Should min-version also really be 26?

This comment has been minimized.

Copy link
@nickvergessen

nickvergessen Oct 24, 2022

Author Member

Yes, on master it is 26, on stable25 it is 25:
https://github.com/nextcloud/bruteforcesettings/blob/stable25/appinfo/info.xml#L28
This app is now shipped and has to go with a 1-1 version mapping going forward.

</dependencies>
<settings>
<admin>OCA\BruteForceSettings\Settings\IPWhitelist</admin>
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "bruteforcesettings",
"version": "2.5.0",
"version": "2.6.0",
"description": "Bruteforce settings app",
"author": "Roeland Jago Douma <roeland@famdouma.nl>",
"license": "AGPL-3.0-or-later",
Expand Down

1 comment on commit 4135ac5

@ordilibre
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I think that "min-version" should stay at 21; 26 is so strict.
Perhaps is the cause to issue 407 : #407

Please sign in to comment.