Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use browser-native UUID function #785

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jaylinski
Copy link

Description

This commit removes the uuid npm-dependency in favor of the browser-native randomUUID-function.

Notes on compatibility

The randomUUID-function is supported by all Nextcloud-supported browsers:

Pros

  • Less dependencies, less supply-chain issues, less renovatebot noise
  • Dependent packages have to install one less dependency
  • When used by the Nextcloud Tasks app, the Tasks app JS bundle will be about 0.32 kB (gzip) smaller

Cons

  • No more compatibility fallback for old browsers

Unsolicited meme

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.57%. Comparing base (23f0114) to head (82d8195).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #785   +/-   ##
=======================================
  Coverage   90.56%   90.57%           
=======================================
  Files          54       55    +1     
  Lines        2640     2642    +2     
  Branches      496      496           
=======================================
+ Hits         2391     2393    +2     
  Misses        223      223           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaylinski jaylinski force-pushed the chore/use-native-uuid branch from 39708d8 to 9f8d627 Compare January 18, 2025 20:48
Signed-off-by: Jakob Linskeseder <jakob@linskeseder.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant