Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user decide their timezone #586

Closed
georgehrke opened this issue Sep 5, 2017 · 7 comments · Fixed by #743
Closed

Let user decide their timezone #586

georgehrke opened this issue Sep 5, 2017 · 7 comments · Fixed by #743
Assignees
Labels
3. to review Waiting for reviews enhancement New feature request

Comments

@georgehrke
Copy link
Member

There are quite a few people having issues with our automatic timezone detection: #496

Furthermore there are scenarios where you want to see the calendar in a different timezone.
Let's say you are on a trip in New York and want to see your calendar for next week, where you gonna be in Germany again, then you will want to see the appointments for next week in the german timezone. Therefore a user should be able to overwrite the timezone setting.

Additionally, users accessing the public sharing site, should also be offered a timezone dropdown.

Where should we place the timezone dropdown?
Settings in calendar or personal settings?
(I was thinking about upper right corner for public sharing site)

Default should always be set to automatic detection.

cc @jancborchardt @leonklingele-work @tcitworld

@georgehrke georgehrke added 1. to develop Accepted and waiting to be taken care of enhancement New feature request labels Sep 5, 2017
@tcitworld
Copy link
Member

There are quite a few people having issues with our automatic timezone detection: #496

Also got a few issues for my users who didn't report here.

I think a timezone setting could go with a new personal setting in server (just like the locale setting - maybe hidden by default - let's talk of this in server ?)
For the public view, I guess your solution is fine.

@leonklingele-work
Copy link

nextcloud/server#6363 brings support to extend the "Personal Settings" page from 3rd party apps in case the timezone selector will not land in server directly.

@jancborchardt
Copy link
Member

Bottom left Calendar setting. That also works on the public page (not top right).

@georgehrke
Copy link
Member Author

I think this should actually be a Nextcloud wide setting because the Tasks app (and maybe others) will need it too.

@jancborchardt
Copy link
Member

Ok, sounds good.

@georgehrke
Copy link
Member Author

There is actually an issue with making it a Nextcloud-wide setting. :/

If we make it a Nextcloud-wide setting, we will most certainly make that value available via some PHP API. But if it's accessible via PHP, we lose the ability to automatically determine the timezone using jstz.

Making it available only via some JS API feels weird because that's usually not how we do things and some developers will probably end up reading the value straight from the database ...

Any thoughts?

@jancborchardt
Copy link
Member

Since we have no implementation at all right now, let’s tackle it in a way which solves it ideally from a UX point of view in the scenarios we need to cover. :)

@georgehrke georgehrke added this to the 1.6.1-next-maintenance milestone Feb 8, 2018
@georgehrke georgehrke self-assigned this Feb 26, 2018
@georgehrke georgehrke added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Feb 26, 2018
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants