\OC\Settings\Personal: Emit 'preRenderForm' event before rendering the personal settings form

[leonklingele-work]

This allows other apps to hook in and add their own section to the
'Personal Settings' page via:

\OC_Hook::connect('\OC\Settings\Personal', 'preFormRender',\
    $this, 'onPreFormRender');

[nickvergessen]

1. We don't use emitter stuff anymore, but the symfony event dispatcher
2. You should be able to register your own setting in your info.xml, for examples see:
   

   server/apps/files_external/appinfo/info.xml

   Lines 32 to 33 in 2cb3461

   	<personal>OCA\Files_External\Settings\Personal</personal>
   	<personal-section>OCA\Files_External\Settings\PersonalSection</personal-section>

[leonklingele-work]

You should be able to register your own setting in your info.xml, for examples see:

This is not what we want to achieve. The info.xml settings you mentioned adds a new tab to the personal settings page, see this screenshot:

We want to extend the 'Personal Info' page directly as shown here:

I had a discussion with @schiessle about this. Please don't close the PR prematurely.

[codecov]

Codecov Report

Merging #6363 into master will decrease coverage by <.01%.
The diff coverage is 36.36%.

@@             Coverage Diff              @@
##             master    #6363      +/-   ##
============================================
- Coverage     54.49%   54.48%   -0.01%     
- Complexity    21220    21223       +3     
============================================
  Files          1313     1313              
  Lines         82440    82449       +9     
  Branches       1329     1329              
============================================
  Hits          44922    44922              
- Misses        37518    37527       +9

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Settings/Manager.php	44.35% <0%> (-1.25%)	75 <2> (+3)
lib/private/Server.php	84.12% <100%> (-0.09%)	123 <0> (ø)
apps/files_trashbin/lib/Trashbin.php	72.28% <0%> (-0.25%)	136% <0%> (ø)

[nickvergessen]

Yeah as mentioned in the chat.
If you dont want your own section, use the existing ones. You can find the IDs in:

server/lib/private/Settings/Manager.php

Line 464 in da6dd48

0 => [new Section('personal-info', $this->l->t('Personal info'), 0, $this->url->imagePath('core', 'actions/info.svg'))],

Additional when this is about timezone/date settings, I would hardcode them in since tasks app, activity and others also make use of this.

[leonklingele-work]

This is indeed already possible without adding any events.
The solution:

1. Add this to your info.xml:

<settings>
	<personal>OCA\YOUR_APP_ID\Settings\Personal</personal>
</settings>

2. Create a Personal class in that namespace which implements OCP\Settings\ISettings, e.g. https://github.com/nextcloud/server/blob/2cb346114685ded69f5291812503c278298c1bce/apps/files_external/lib/Settings/Personal.php
3. Make sure getSection() returns 'personal-info'
4. Increase your app's version
5. Run the upgrader

EDIT:

• Fix typo
• Add getSection() step