Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused webpack alias config #2494

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Conversation

georgehrke
Copy link
Member

@georgehrke georgehrke commented Aug 22, 2020

Also adds symlink: false, which is part of our standard conf: https://github.com/nextcloud/webpack-vue-config/blob/master/webpack.js#L65

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke added the 3. to review Waiting for reviews label Aug 22, 2020
@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #2494 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2494   +/-   ##
=========================================
  Coverage     30.47%   30.47%           
  Complexity      103      103           
=========================================
  Files           146      146           
  Lines          5365     5365           
  Branches        802      802           
=========================================
  Hits           1635     1635           
  Misses         3730     3730           
Flag Coverage Δ Complexity Δ
#javascript 25.40% <ø> (ø) 0.00 <ø> (ø)
#php 94.41% <ø> (ø) 103.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b5ff4...09581f6. Read the comment docs.

@georgehrke georgehrke requested a review from tcitworld August 22, 2020 11:11
@georgehrke georgehrke merged commit 81df418 into master Aug 25, 2020
@georgehrke georgehrke deleted the meta/noid/webpack_cleanup branch August 25, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants