Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues introduced with nc/vue 2.6 #2505

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

georgehrke
Copy link
Member

No description provided.

@georgehrke georgehrke added the 2. developing Work in progress label Aug 24, 2020
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #2505 into master will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2505   +/-   ##
=========================================
  Coverage     30.47%   30.48%           
  Complexity      103      103           
=========================================
  Files           146      146           
  Lines          5365     5367    +2     
  Branches        802      804    +2     
=========================================
+ Hits           1635     1636    +1     
- Misses         3730     3731    +1     
Flag Coverage Δ Complexity Δ
#javascript 25.41% <50.00%> (+<0.01%) 0.00 <0.00> (ø)
#php 94.41% <ø> (ø) 103.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/models/rfcProps.js 100.00% <ø> (ø) 0.00 <0.00> (ø)
src/store/calendars.js 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/views/Calendar.vue 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/views/EditSidebar.vue 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/fullcalendar/eventSourceFunction.js 94.11% <50.00%> (-1.81%) 0.00 <0.00> (ø)
src/fullcalendar/eventSource.js 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6916668...dbe480f. Read the comment docs.

@georgehrke georgehrke force-pushed the bugfix/noid/fix_nc_vue_2.6_regressions branch from a13e5fc to e26c7e3 Compare August 25, 2020 10:29
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the bugfix/noid/fix_nc_vue_2.6_regressions branch from e26c7e3 to dbe480f Compare August 25, 2020 10:42
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 25, 2020
@georgehrke georgehrke requested a review from tcitworld August 25, 2020 10:43
@georgehrke georgehrke merged commit 84b2d4b into master Aug 25, 2020
@georgehrke georgehrke deleted the bugfix/noid/fix_nc_vue_2.6_regressions branch August 25, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants