Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix layout issues of calendar sharing #2509

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Fix layout issues of calendar sharing #2509

merged 1 commit into from
Aug 26, 2020

Conversation

georgehrke
Copy link
Member

Before After
45B2F4D0-092C-458E-9F4A-044371A3DF7E 4643A68C-B760-4DF7-96BB-C0E4FA42BB2D

@georgehrke
Fix layout issues of calendar sharing
86e561f 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke added the 3. to review Waiting for reviews label Aug 26, 2020
@codecov
Copy link

codecov bot commented Aug 26, 2020 •
edited
Loading

Codecov Report

Merging #2509 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2509   +/-   ##
=========================================
  Coverage     30.48%   30.48%           
  Complexity      103      103           
=========================================
  Files           146      146           
  Lines          5367     5367           
  Branches        804      804           
=========================================
  Hits           1636     1636           
  Misses         3731     3731
Flag Coverage Δ Complexity Δ
#javascript 25.41% <ø> (ø) 0.00 <ø> (ø)
#php 94.41% <ø> (ø) 103.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/views/EditSidebar.vue 0.00% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81df418...86e561f. Read the comment docs.

@georgehrke
Copy link
Member Author

/backport to stable2.0

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Aug 26, 2020
@georgehrke georgehrke merged commit a62cb69 into master Aug 26, 2020
@georgehrke georgehrke deleted the bugfix/noid/sharing_dialog_fix branch August 26, 2020 11:21
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 26, 2020
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgehrke @nickvergessen