Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings scroll problem #3026

Closed
wants to merge 1 commit into from
Closed

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Apr 16, 2021

fixes #2967

before - check fixes

after
aftercalendarsettings

Signed-off-by: GretaD <gretadoci@gmail.com>
@GretaD GretaD self-assigned this Apr 16, 2021
@GretaD GretaD added 3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. labels Apr 16, 2021
@GretaD GretaD requested a review from ChristophWurst April 16, 2021 10:42
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #3026 (10bf92b) into master (e79296b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3026   +/-   ##
=========================================
  Coverage     29.18%   29.18%           
  Complexity      116      116           
=========================================
  Files           155      155           
  Lines          5561     5561           
  Branches        822      822           
=========================================
  Hits           1623     1623           
  Misses         3938     3938           
Flag Coverage Δ Complexity Δ
javascript 23.85% <ø> (ø) 0.00 <ø> (ø)
php 94.29% <ø> (ø) 116.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79296b...10bf92b. Read the comment docs.

@GretaD GretaD requested a review from tcitworld April 16, 2021 10:43
@raimund-schluessler
Copy link
Member

raimund-schluessler commented Apr 16, 2021

I think overflow: visible is there to prevent issues with the multiselects for timezone and duration. overflow: auto makes it difficult to select a value and leads to a scrollbar in y-direction for some locals. At least this was the status of the discussion in #2516.

@GretaD
Copy link
Contributor Author

GretaD commented Apr 16, 2021

I think overflow: visible is there to prevent issues with the multiselects for timezone and duration. overflow: auto makes it difficult to select a value and leads to a scrollbar in y-direction for some locals. At least this was the status of the discussion in #2516.

ohh i see, thank you for pointing it out, i was trying to find smth if it was done on purpose but failed. So I guess, would be better to put the whole settings into a modal and this way we fix the "crowed" problem and this bug.

@GretaD
Copy link
Contributor Author

GretaD commented Apr 16, 2021

We decided on Groupware channel to move settings into a modal, so it will be fixed there.

@GretaD GretaD closed this Apr 16, 2021
@raimund-schluessler raimund-schluessler deleted the fix/Settings-and-import-scroll branch September 7, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar moves/scrolls when I open Settings and Import
2 participants