-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move settings into a modal #3041
Conversation
@@ -20,10 +20,20 @@ | |||
--> | |||
|
|||
<template> | |||
<AppNavigationSettings :title="settingsTitle"> | |||
<ul class="settings-fieldset-interior"> | |||
<!-- <AppNavigationSettings icon="icon-settings" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
calendar doesnt have a navigation or sidebar component, so need to find a way where to add this
Codecov Report
@@ Coverage Diff @@
## master #3041 +/- ##
============================================
- Coverage 29.18% 29.15% -0.04%
Complexity 116 116
============================================
Files 155 155
Lines 5561 5567 +6
Branches 822 822
============================================
Hits 1623 1623
- Misses 3938 3944 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
b6011d3
to
207dc8f
Compare
Signed-off-by: GretaD <gretadoci@gmail.com>
207dc8f
to
563a152
Compare
this is a very old ticket that i dont have the time to work on it now. I am closing it just to make sure that if somebody wants to help they can. And if we decide to prioritize it on our Groupware roadmap, would be happy to have another look. |
WIP