Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move settings into a modal #3041

Closed
wants to merge 1 commit into from
Closed

Move settings into a modal #3041

wants to merge 1 commit into from

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Apr 26, 2021

WIP

@@ -20,10 +20,20 @@
-->

<template>
<AppNavigationSettings :title="settingsTitle">
<ul class="settings-fieldset-interior">
<!-- <AppNavigationSettings icon="icon-settings"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calendar doesnt have a navigation or sidebar component, so need to find a way where to add this

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #3041 (563a152) into master (243f995) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3041      +/-   ##
============================================
- Coverage     29.18%   29.15%   -0.04%     
  Complexity      116      116              
============================================
  Files           155      155              
  Lines          5561     5567       +6     
  Branches        822      822              
============================================
  Hits           1623     1623              
- Misses         3938     3944       +6     
Flag Coverage Δ Complexity Δ
javascript 23.82% <0.00%> (-0.03%) 0.00 <0.00> (ø)
php 94.29% <ø> (ø) 116.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/components/AppNavigation/Settings.vue 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 243f995...563a152. Read the comment docs.

@GretaD GretaD force-pushed the enhancement/settings-modal branch from b6011d3 to 207dc8f Compare April 26, 2021 10:11
@ChristophWurst ChristophWurst changed the title Add settings into a modal Move settings into a modal Apr 26, 2021
Signed-off-by: GretaD <gretadoci@gmail.com>
@GretaD GretaD force-pushed the enhancement/settings-modal branch from 207dc8f to 563a152 Compare April 26, 2021 10:16
@tcitworld tcitworld self-requested a review April 26, 2021 10:21
@tcitworld tcitworld added 2. developing Work in progress javascript Pull requests that update Javascript code labels Apr 26, 2021
@tcitworld
Copy link
Member

#2304

@GretaD
Copy link
Contributor Author

GretaD commented Mar 24, 2022

this is a very old ticket that i dont have the time to work on it now. I am closing it just to make sure that if somebody wants to help they can. And if we decide to prioritize it on our Groupware roadmap, would be happy to have another look.

@GretaD GretaD closed this Mar 24, 2022
@ChristophWurst ChristophWurst deleted the enhancement/settings-modal branch March 24, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants