Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP:allow the user to specify the day the weeks starts #335

Closed
wants to merge 1 commit into from
Closed

WIP:allow the user to specify the day the weeks starts #335

wants to merge 1 commit into from

Conversation

adsworth
Copy link

@adsworth adsworth commented Feb 8, 2017

Hi,

this PR allows the user to specify the day the weeks starts irrespective of their language.
As I'm a web development noob all input is welcome.

Saving of the the settings on the server doesn't yet work. I'll have to look into that.

@mention-bot
Copy link

@adsworth, thanks for your PR! By analyzing the history of the files in this pull request, we identified @georgehrke, @tcitworld and @peternowee to be potential reviewers.

@georgehrke
Copy link
Member

Hm :/

We intentionally decided against offering that option. There will be a locale / region setting in the server

@georgehrke
Copy link
Member

cc @jancborchardt

@adsworth
Copy link
Author

adsworth commented Feb 8, 2017

@georgehrke good that I asked before hand. :)
Well if you decide against it, jut close the PR. Maybe then I could start the implementation in the server and once that is there, take it up here again. :)

@georgehrke
Copy link
Member

You can find the core issue here: nextcloud/server#1781

@tcitworld
Copy link
Member

Closing here then.

@tcitworld tcitworld closed this Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants