Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsdoc/tag-lines #3459

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Fix jsdoc/tag-lines #3459

merged 1 commit into from
Sep 8, 2021

Conversation

raimund-schluessler
Copy link
Member

This fixes the jsdoc/tag-lines warnings after #3410.

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #3459 (0015d64) into master (c39443c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3459   +/-   ##
=========================================
  Coverage     28.21%   28.21%           
  Complexity      123      123           
=========================================
  Files           163      163           
  Lines          5826     5826           
  Branches        853      853           
=========================================
  Hits           1644     1644           
  Misses         4182     4182           
Flag Coverage Δ
javascript 22.71% <ø> (ø)
php 94.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/dashboard.js 0.00% <ø> (ø)
src/defaults/defaultAlarmProvider.js 100.00% <ø> (ø)
src/defaults/defaultCategories.js 100.00% <ø> (ø)
src/directives/autosize.js 0.00% <ø> (ø)
src/directives/focus.js 0.00% <ø> (ø)
src/directives/linkify.js 0.00% <ø> (ø)
src/filters/alarmFormat.js 100.00% <ø> (ø)
src/filters/dateFormat.js 100.00% <ø> (ø)
src/filters/dateRangeFormat.js 100.00% <ø> (ø)
src/filters/recurrenceRuleFormat.js 82.00% <ø> (ø)
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39443c...0015d64. Read the comment docs.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad that this rule got fixed upstream.

@st3iny st3iny merged commit b12b1d5 into master Sep 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/3410/jsdoc branch September 8, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants