Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show proper am/pm labels next to timepicker #346

Merged
merged 1 commit into from
Feb 20, 2017

Conversation

georgehrke
Copy link
Member

fixes #345

please review @tcitworld @skjnldsv

before:

after:
calendar - nextcloud chromium today at 11 11 57 am

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@mention-bot
Copy link

@georgehrke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @raghunayyar and @peternowee to be potential reviewers.

@georgehrke georgehrke added the 3. to review Waiting for reviews label Feb 20, 2017
@georgehrke
Copy link
Member Author

PS: this will only show up if you use the 12h format. When you select a language like german (with 24h), you won't see these labels.

Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works

@tcitworld tcitworld merged commit f8be032 into master Feb 20, 2017
@tcitworld tcitworld deleted the bugfix/345/am_pm_labels branch February 20, 2017 11:58
@skjnldsv
Copy link
Member

👍 nice.

How can I know which language comes with a h24? Can I use en with h24 format?

@georgehrke
Copy link
Member Author

Can I use en with h24 format?

No, not yet.
See nextcloud/server#1781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timepicker ununderstandable
4 participants