Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Share link action if calendar publishing is disabled #5679

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

pboguslawski
Copy link
Contributor

This mod removes Share link action in calendar edit dialog when publishing is disabled for this calendar. Was tested with nextcloud/server#34873 applied to nextcloud-server v28.

Related: nextcloud/server#34873 (comment)
Author-Change-Id: IB#1126264

Related: nextcloud/server#34873
Author-Change-Id: IB#1126264
Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d520471) 24.45% compared to head (4a9f810) 24.44%.
Report is 26 commits behind head on main.

Files Patch % Lines
src/components/AppNavigation/EditCalendarModal.vue 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5679      +/-   ##
============================================
- Coverage     24.45%   24.44%   -0.02%     
  Complexity      418      418              
============================================
  Files           243      243              
  Lines         10857    10863       +6     
  Branches       1780     1782       +2     
============================================
  Hits           2655     2655              
- Misses         8202     8208       +6     
Flag Coverage Δ
javascript 15.52% <0.00%> (-0.02%) ⬇️
php 61.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pboguslawski pboguslawski changed the title Remove publish link is calendar publishing is disabled Remove Share link action if calendar publishing is disabled Jan 10, 2024
@st3iny
Copy link
Member

st3iny commented Jan 15, 2024

@pboguslawski Thank you for the PR.

Am I correct in the assumption, that we need the server PR or does this already work without the linked server PR? If so, I'd like to merge this soon.

@pboguslawski
Copy link
Contributor Author

We use nextcloud server source with nextcloud/server#34873 applied and didn't tested without it. This PR uses param this.calendar.canBePublished already present in calendar source so will work even without nextcloud/server#34873 probably.

Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not checkout the server PR.

Sharee's new view without edit rights:

image

With edit rights:

image

Nice!

@miaulalala miaulalala added this to the v4.7.0 milestone Jan 17, 2024
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 17, 2024
@st3iny st3iny merged commit 1e9f89d into nextcloud:main Jan 17, 2024
0 of 2 checks passed
@pboguslawski pboguslawski deleted the main-IB#1126264 branch January 17, 2024 15:06
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish Feature: Public sharing feedback-requested
Projects
Development

Successfully merging this pull request may close these issues.

3 participants