-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Share link action if calendar publishing is disabled #5679
Conversation
Related: nextcloud/server#34873 Author-Change-Id: IB#1126264 Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5679 +/- ##
============================================
- Coverage 24.45% 24.44% -0.02%
Complexity 418 418
============================================
Files 243 243
Lines 10857 10863 +6
Branches 1780 1782 +2
============================================
Hits 2655 2655
- Misses 8202 8208 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@pboguslawski Thank you for the PR. Am I correct in the assumption, that we need the server PR or does this already work without the linked server PR? If so, I'd like to merge this soon. |
We use nextcloud server source with nextcloud/server#34873 applied and didn't tested without it. This PR uses param |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
This mod removes
Share link
action in calendar edit dialog when publishing is disabled for this calendar. Was tested with nextcloud/server#34873 applied to nextcloud-server v28.Related: nextcloud/server#34873 (comment)
Author-Change-Id: IB#1126264