-
Notifications
You must be signed in to change notification settings - Fork 284
fix: meeting proposals participant no reponse #7396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7396 +/- ##
==========================================
- Coverage 13.64% 13.56% -0.08%
==========================================
Files 218 218
Lines 11209 11274 +65
Branches 2706 2723 +17
==========================================
Hits 1529 1529
- Misses 9327 9385 +58
- Partials 353 360 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Some feed back was to indicate which users did no respond |
|
Nice! Good point, we should include that so ppl can poke them and remind them to respond (also could be a follow up feature to just allow this with a button). One thing I'm noticing here is that it could be confusing which icon is tentative and which one is no response yet (especially because we use a little Maybe specifying how many people actually responded inside the modal could help? Maybe another row in the details with |
I've aligned the icons and colours with event attendance. Also, I made the icon background less in your face.
Sure, I can add this. But where in the details? |
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
698ac6d to
617c607
Compare
|
@SebastianKrupinski Ready to review or still developing? Regarding:
|
Just waiting for designer feedback, sorry should have changed the status to draft |
|
@nimishavijay ^^ please |
|
/backport to stable6.0 |
Summary