Skip to content

Conversation

@SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented Sep 10, 2025

Summary

  • Modified vote matrix to indicate which users have not responded
image image image

@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.56%. Comparing base (bf1aa36) to head (617c607).
⚠️ Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Proposal/ProposalResponseMatrix.vue 0.00% 3 Missing ⚠️
src/views/Proposal/ProposalEditor.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7396      +/-   ##
==========================================
- Coverage   13.64%   13.56%   -0.08%     
==========================================
  Files         218      218              
  Lines       11209    11274      +65     
  Branches     2706     2723      +17     
==========================================
  Hits         1529     1529              
- Misses       9327     9385      +58     
- Partials      353      360       +7     
Flag Coverage Δ
javascript 13.56% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SebastianKrupinski
Copy link
Contributor Author

@nimishavijay

Some feed back was to indicate which users did no respond

@nimishavijay
Copy link
Member

nimishavijay commented Sep 11, 2025

Nice! Good point, we should include that so ppl can poke them and remind them to respond (also could be a follow up feature to just allow this with a button).

One thing I'm noticing here is that it could be confusing which icon is tentative and which one is no response yet (especially because we use a little ? icon in calendar for the awaiting response state).

Maybe specifying how many people actually responded inside the modal could help? Maybe another row in the details with
👤 5 participants, 3 responded?

@SebastianKrupinski
Copy link
Contributor Author

One thing I'm noticing here is that it could be confusing which icon is tentative and which one is no response yet (especially because we use a little ? icon in calendar for the awaiting response state).

I've aligned the icons and colours with event attendance. Also, I made the icon background less in your face.

Maybe specifying how many people actually responded inside the modal could help? Maybe another row in the details with 👤 5 participants, 3 responded?

Sure, I can add this. But where in the details?

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski force-pushed the fix/meeting-proposals-no-response branch from 698ac6d to 617c607 Compare September 11, 2025 20:36
@st3iny
Copy link
Member

st3iny commented Sep 12, 2025

@SebastianKrupinski Ready to review or still developing?

Regarding:

Sure, I can add this. But where in the details?

@SebastianKrupinski
Copy link
Contributor Author

@SebastianKrupinski Ready to review or still developing?

Just waiting for designer feedback, sorry should have changed the status to draft

@SebastianKrupinski
Copy link
Contributor Author

@nimishavijay ^^ please

@st3iny st3iny enabled auto-merge September 22, 2025 12:34
@st3iny st3iny added bug design Related to design, interface, interaction design, UX, etc. 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 22, 2025
@st3iny st3iny merged commit 6e098e4 into main Sep 22, 2025
47 of 53 checks passed
@st3iny st3iny deleted the fix/meeting-proposals-no-response branch September 22, 2025 12:35
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Sep 22, 2025
@SebastianKrupinski
Copy link
Contributor Author

/backport to stable6.0

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Sep 22, 2025
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug design Related to design, interface, interaction design, UX, etc.

Projects

Development

Successfully merging this pull request may close these issues.

5 participants