Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/remove broken scripts #1521

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix/remove broken scripts #1521

merged 1 commit into from
Mar 6, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Mar 6, 2024

We need to migrate those scripts to the new files API but this is more work there is currently no time. It seems those scripts can cause failures as reported in #1434

As they don't work right now there is no need to load them and this also has been a regular annoyance when running cypress tests locally where the random console errors cause failures.

Left the script files in place to know what to implement with the new API.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@VGerris
Copy link

VGerris commented Mar 6, 2024

Just some comments, thanks for linking to the other issue.
What do you mean with no time ? As in lower priority?
If anyone has a good quick getting-starting to developing that part, I might give it a shot.
Perhaps good to rename those scripts with something in the name indicating they need to be reimplemented or removed , like filename.a -> filename-disabled-needs-api-impl-ticket1521.a or something.
And also good to determine impact of this, it may be quite serious and as such be more priority than initially thought.
Thank you!

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juliushaertl, I had planned to do something similar 🙈

@mejo- mejo- merged commit cd69b00 into master Mar 6, 2024
20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/remove-broken-scripts branch March 6, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants