fix: use shared_by user in share mail if initiator is not set #2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
share-mail-shared-by
branch
from
53740a5 to
e144b0b
Compare
Member
Author
|
Also includes test bootstrap fix for nextcloud/server#52945 |
ArtificialOwl
approved these changes
Jun 27, 2025
provokateurin
approved these changes
Jun 27, 2025
Member
|
@icewind1991 please rebase |
icewind1991
force-pushed
the
share-mail-shared-by
branch
from
c96066b to
a810bf0
Compare
salmart-dev
force-pushed
the
share-mail-shared-by
branch
from
a810bf0 to
ca8403b
Compare
salmart-dev
force-pushed
the
share-mail-shared-by
branch
2 times, most recently
from
6765a94 to
cdbbee7
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
salmart-dev
force-pushed
the
share-mail-shared-by
branch
from
7b1da2a to
e56350e
Compare
provokateurin
requested changes
Jul 7, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Please revert the cs-fixer changes and rebase on master. The issue with it in the CI has been solved: #2043
Other than that this looks good, just needs a squash.
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
salmart-dev
force-pushed
the
share-mail-shared-by
branch
from
e56350e to
3aa58b7
Compare
provokateurin
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1447