fix: replace circle/circles text with team/teams#2226
Merged
yemkareems merged 1 commit intomasterfrom Nov 19, 2025
Merged
Conversation
Signed-off-by: yemkareems <yemkareems@gmail.com>
ArtificialOwl
approved these changes
Nov 19, 2025
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
rakekniven
reviewed
Jan 3, 2026
Member
rakekniven
left a comment
rakekniven
left a comment
There was a problem hiding this comment.
In general use lowercase for team
| $this->setName('circles:manage:config') | ||
| ->setDescription('edit config/type of a Circle') | ||
| ->addArgument('circle_id', InputArgument::REQUIRED, 'ID of the circle') | ||
| ->setDescription('edit config/type of a Team') |
| ->addArgument( | ||
| 'config', InputArgument::IS_ARRAY, | ||
| 'list of value to change in the configuration of the Circle' | ||
| 'list of value to change in the configuration of the Team' |
| $this->setName('circles:manage:edit') | ||
| ->setDescription('edit displayName or description of a Circle') | ||
| ->addArgument('circle_id', InputArgument::REQUIRED, 'ID of the circle') | ||
| ->setDescription('edit displayName or description of a Team') |
| $this->setName('circles:manage:leave') | ||
| ->setDescription('simulate a user joining a Circle') | ||
| ->addArgument('circle_id', InputArgument::REQUIRED, 'ID of the circle') | ||
| ->setDescription('simulate a user joining a Team') |
| ->addOption('backend', '', InputOption::VALUE_NONE, 'include Backend Circles') | ||
| ->addOption('single', '', InputOption::VALUE_NONE, 'returns only Single Circles') | ||
| ->addOption('all', '', InputOption::VALUE_NONE, 'include all Circles'); | ||
| ->addOption('personal', '', InputOption::VALUE_NONE, 'include Personal Teams') |
| $instances = $this->memberRequest->getMemberInstances($event->getCircle()->getSingleId()); | ||
| if (!in_array($event->getSender(), $instances)) { | ||
| throw new FederatedEventException('Instance have no members in this Circle'); | ||
| throw new FederatedEventException('Instance have no members in this Team'); |
| } | ||
|
|
||
| throw new FederatedEventDSyncException('Could not verify Circle'); | ||
| throw new FederatedEventDSyncException('Could not verify Team'); |
| 128 => 'Cannot add Circle as its own Member', | ||
| 125 => 'The designed team cannot be added', | ||
| 126 => 'Team only accepts local users', | ||
| 127 => 'Remote Users are not accepted in a non-federated Team', |
| 125 => 'The designed team cannot be added', | ||
| 126 => 'Team only accepts local users', | ||
| 127 => 'Remote Users are not accepted in a non-federated Team', | ||
| 128 => 'Cannot add Team as its own Member', |
| 129 => 'Member does not contains a patron', | ||
| 130 => 'Member is invited by an entity that does not belongs to the instance at the origin of the request', | ||
| 131 => 'Member is a non-local Circle', | ||
| 131 => 'Member is a non-local Team', |
Contributor
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2219
fix: replace circle/circles text with team/teams