Skip to content

Conversation

@cristianscheid
Copy link
Contributor

@cristianscheid cristianscheid commented Jan 17, 2026

Summary

Fixes team population calculation to exclude nested teams from member counts.

Changes

  • When a team is added as member of another team, only users within the nested team are counted (team itself and duplicates are not counted)
  • When team members are added/removed, all parent circles (circles containing the updated circle) are also updated
  • When a team is deleted, all teams that contained that team are updated to reflect the removal
  • Added populationInherited field to Circle::jsonSerialize() alongside existing population for frontend usage in follow-up PR without breaking current frontend

Frontend follow-up needed

This PR addresses only the backend part of the issue. A follow-up PR in nextcloud/contacts is required to fix inconsistent count display:

  • Currently: uses population for member count on page load, but switches to member list length when clicking a team
  • Expected: consistently use the same count throughout the interface (populationInherited, added in this PR)

Checklist

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid cristianscheid merged commit 4bac2ab into master Jan 19, 2026
44 checks passed
@cristianscheid cristianscheid deleted the bug/2126/team-member-count branch January 19, 2026 14:42
@cristianscheid
Copy link
Contributor Author

/backport to stable31

@cristianscheid
Copy link
Contributor Author

/backport to stable32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants